ACP Loading Extremely slow - 1.8.1

[yapne]

Hi,

I have downloaded 1.8.1 to test and i realised loading the ACP page takes about 15 seconds. In the logs i'm seeing multi error message in the below. I'm sitting behind a corporate proxy server and firewall and i suspect the request going out to github is blocked.

I did a hack on the request code in \NodeBB-1.8.1\src\admin\versions.js to include a proxy and the error dissapears and ACP loads immediately. This wasn't an issue in 1.7.5v and i believe there were changes made to some files.

I'm seeing this problem too in ACP plugin whereby i can't search for plugin because of the same issue. Is there a way to set PROXY in NodeBB?

Thanks

Nelson

2018-03-26T20:05:16.187Z [16500] - error: [acp] Failed to fetch latest version Error: getaddrinfo ENOTFOUND api.github.com api.github.com:443
at errnoException (dns.js:28:10)
at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:76:26)

[PitaJ]

That error shouldn't cause any issues, it's specifically written to avoid breaking things.

The reason the ACP takes so long to load the first time is because after you upgrade, it has to recompile the template when you first request the page.

[yapne]

@pitaj even subsequent tries are slow as well because the DNS.js has some sort of timeout setting before erroring out. This is a new install rather than upgrade.

[PitaJ]

Anyways, it looks like I could enable setting the proxy parameter, and possibly lower the timeout value for the request to speed things up.

[yapne]

@pitaj thank you. Will this be available in 1.8.2?

[PitaJ]

@yapne probably

[yapne]

@pitaj did this make it to 1.8.2? Thanks