plugin-assign-new-user-to-group not working after upgrade from v1.5.x to v1.6.x
-
I opened an issue on github:
https://github.com/pichalite/nodebb-plugin-assign-newuser-to-group/issues/2
Can anybody help?
closed Module doesn't work with nodebb v1.6.x #2
-
Sent a PR to fix the issue. The hook parameter changed so that's why it wasn't working.
-
Sorry for my ignorance, but isn't it enough to open an issue on Github?
Also where to sent a PR and how?Sorry again, I'm not yet familiar with the handling
-
@wellenreiter no worries, I fixed the issue and sent a pull request to @pichalite 's repository on github. When he merges my changes the issue will be fixed.
-
Thanks a lot
Can the changed hook also be the cause for this problem I have?
Sorry for asking more noob questions
-
@wellenreiter you just linked this topic, did you mean to link to something else?
-
Oh sorry, my fault.
This is the right link.
-
@wellenreiter no I don't believe it will fix that, as these are different plugins entirely.
-
To bad,
where to send a PR for this one?
-
@wellenreiter you may be confused on what a PR is. Are you a developer? because a PR is a way to contribute your coding skills to the plugin. When you make a PR, you are essentially fixing the plugin yourself.
PRs are submitted on the plugin's Github page. PR stands for Pull Request.
-
lol,
ok. Forgive my lack of lagnuage skills.I have a github account, and of course know what a pull request is.
No experience with nodebb so...
-
I have implemented your changes manually to my installation and assign-new-user-to group works fine again.
Many thanks
P.S: I can't flag the problem as solved. can you do it?
-
@wellenreiter said in plugin-assign-new-user-to-group not working after upgrade from v1.5.x to v1.6.x:
P.S: I can't flag the problem as solved. can you do it?
Are you getting any error messages when trying to mark as solved?
-
@baris
no, just I got an empty pull down menu when I clicked Topic Tools.Today I tried again, and got the pull down popolated.
Strange....
