plugin-assign-new-user-to-group not working after upgrade from v1.5.x to v1.6.x

wellenreiter

I opened an issue on github:

https://github.com/pichalite/nodebb-plugin-assign-newuser-to-group/issues/2

Can anybody help?

<baris>

Sent a PR to fix the issue. The hook parameter changed so that's why it wasn't working.

wellenreiter

@baris

Sorry for my ignorance, but isn't it enough to open an issue on Github?
Also where to sent a PR and how?

Sorry again, I'm not yet familiar with the handling

<baris>

@wellenreiter no worries, I fixed the issue and sent a pull request to @pichalite 's repository on github. When he merges my changes the issue will be fixed.

wellenreiter

Thanks a lot

Can the changed hook also be the cause for this problem I have?

https://community.nodebb.org/topic/11469/plugin-assign-new-user-to-group-not-working-after-upgrade-from-v1-5-x-to-v1-6-x

Sorry for asking more noob questions

PitaJ

@wellenreiter you just linked this topic, did you mean to link to something else?

wellenreiter

Oh sorry, my fault.

https://community.nodebb.org/topic/11256/nodebb-rewards-essentials-after-upgrade-errorillegal-reward-no-inputs-found/

This is the right link.

PitaJ

@wellenreiter no I don't believe it will fix that, as these are different plugins entirely.

wellenreiter

To bad,

where to send a PR for this one?

PitaJ

@wellenreiter you may be confused on what a PR is. Are you a developer? because a PR is a way to contribute your coding skills to the plugin. When you make a PR, you are essentially fixing the plugin yourself.

PRs are submitted on the plugin's Github page. PR stands for Pull Request.

wellenreiter

lol,
ok. Forgive my lack of lagnuage skills.

I have a github account, and of course know what a pull request is.

No experience with nodebb so...

wellenreiter

@baris

I have implemented your changes manually to my installation and assign-new-user-to group works fine again.

Many thanks

P.S: I can't flag the problem as solved. can you do it?

<baris>

@wellenreiter said in plugin-assign-new-user-to-group not working after upgrade from v1.5.x to v1.6.x:

P.S: I can't flag the problem as solved. can you do it?

Are you getting any error messages when trying to mark as solved?

wellenreiter

@baris
no, just I got an empty pull down menu when I clicked Topic Tools.

Today I tried again, and got the pull down popolated.

Strange....