Profile picture cropping modal issue

PitaJ

Try running npm i cropperjs@latest in the nodebb directory and then rebuilding and restarting.

Edit: I tried accessing a few files that should exist on your site. It looks like files such as these:

build/public/src/modules/cropper.js
build/public/src/modules/Chart.js
build/public/src/modules/mousetrap.js

...aren't there. If you're using Heroku, make sure those files are not ignored in your git repo.

Readerly

That's odd. I'm looking in the build/public/src/modules/ directory. Those files you mention are aliases.

PitaJ

Yes, they are symlinks to files in node_modules.

Readerly

The .gitignore file in the NodeBB directory includes node_modules/

Could that be why those 3 files aren't being pushed to Heroku?

PitaJ

I doubt it, because node_modules should be installed when Heroku starts up, otherwise NodeBB wouldn't work at all.

It could be that they are absolute symlinks, which would break when sent up to Heroku. Can you inspect the link targets?

readlink build/public/src/modules/cropper.js etc

Readerly

Here's the link target for build/public/src/modules/cropper.js

/node_modules/cropperjs/dist/cropper.min.js

And build/public/src/modules/Chart.js:

node_modules/chart.js/dist/Chart.min.js

And build/public/src/modules/mousetrap.js:

node_modules/mousetrap/mousetrap.min.js

PitaJ

Are those the exact readouts from readlink?

I get different results.

Readerly

Exact readouts:

/Users/seanmiller/Documents/nodebb/NodeBB/node_modules/cropperjs/dist/cropper.min.js
/Users/seanmiller/Documents/nodebb/NodeBB/node_modules/chart.js/dist/Chart.min.js
/Users/seanmiller/Documents/nodebb/NodeBB/node_modules/mousetrap/mousetrap.min.js

These look pretty absolute, yes?

PitaJ

Ok so the issue is indeed because the links are absolute. I'll see if I can get a fix. In the meantime, you should be able to use this command on those files:

cp --remove-destination `readlink cropper.js` cropper.js

Readerly

Success! I guess we found a bug. Thanks so much for your help, @PitaJ. It's much appreciated.

Readerly

Hey @PitaJ,

I think I found another absolute symlink:

readlink /build/public/plugins/nodebb-plugin-markdown/styles

gives:

/Users/seanmiller/Documents/nodebb/NodeBB/node_modules/nodebb-plugin-markdown/public/styles

In that same directory, readlink js yields:

/Users/seanmiller/Documents/nodebb/NodeBB/node_modules/nodebb-plugin-markdown/public/js

It may be that all the symlinks are absolute in this build.

Missing a railscasts.css causes this:

404 Not Found
Route Count
/plugins/nodebb-plugin-markdown/styles/railscasts.css 59

PitaJ

Yep those should be fixed as well

Readerly

Hi @PitaJ

I replaced those absolute folder symlinks in the plugins directories with the actual folders and their contents. I'm still getting these errors in my console logs when I load pages, though:

404 Not Found
Route Count
/plugins/nodebb-plugin-markdown/styles/railscasts.css 96
/assets/uploads/profile/1-profileavatar.png 9

The odd thing is that it's only happening in Chrome, not Firefox:

forum.driversbydesign.com/:35 GET http://forum.driversbydesign.com/plugins/nodebb-plugin-markdown/styles/railscasts.css net::ERR_ABORTED
(index):322 GET http://forum.driversbydesign.com/assets/uploads/profile/1-profileavatar.png 404 (Not Found)

PitaJ

Try clearing your cache.

Readerly

Do you mean the browser cache?

Did that. Now both Firefox and Chrome are spitting out the following errors in the console log:

Firefox:
GET http://forum.driversbydesign.com/plugins/nodebb-plugin-markdown/styles/railscasts.css [HTTP/1.1 404 Not Found 92ms]

Chrome:
Failed to load resource: the server responded /plugins/nodebb-plugin-markdown/styles/railscasts.css
1-profileavatar.png Failed to load resource: the server responded with a status of 404 (Not Found)
railscasts.css Failed to load resource: the server responded with a status of 404 (Not Found)

Readerly

Hi @PitaJ,

I'm still having an issue with NodeBB not being about to find a profile picture I set up on my (admin) profile. It happens on Firefox or Chrome. It's hard to discern a pattern--why some actions cause the browser not to be able to load the image, while the other still can.

Any other suggestions?

Sean