Upvoting and downvoting causes NodeBB crash / restart

[btc]

NodeJS - 6.11.1
NodeBB - 1.5.2
NPM - 5.3.0
Redis - 4.0.0
CentOS - 6.9

As per the title, voting on a post causes a crash. Browser error is the "connection lost, please wait while we reconnect" one.

Error in logs is:

24/7 12:50:30 [12789] - error: TypeError: callback is not a function
at Command.callback (/usr/bin/nodebb/src/database/redis/sorted.js:184:4)
at normal_reply (/usr/bin/nodebb/node_modules/redis/index.js:721:21)
at RedisClient.return_reply (/usr/bin/nodebb/node_modules/redis/index.js:819:9)
at JavascriptRedisParser.returnReply (/usr/bin/nodebb/node_modules/redis/index.js:192:18)
at JavascriptRedisParser.execute (/usr/bin/nodebb/node_modules/redis-parser/lib/parser.js:574:12)
at Socket.<anonymous> (/usr/bin/nodebb/node_modules/redis/index.js:274:27)
at emitOne (events.js:96:13)
at Socket.emit (events.js:188:7)
at readableAddChunk (_stream_readable.js:176:18)
at Socket.Readable.push (_stream_readable.js:134:10)
at TCP.onread (net.js:547:20)

[btc]

Bump... still having this problem, anyone have any ideas?

[MJ]

Had the same problem a few months ago. It was with on 0.9.x to 1.0.x by the next update I did it was gone. Maybe you can try upgrade again maybe it helps, or maybe it is solved when 1.6.2 is out.

[baris]

@btc Can you post a list of plugins you have active? Run ./nodebb plugins to get the list.

[btc]

@baris Thanks, here you go:

     - nodebb-plugin-composer-default
     - nodebb-plugin-dbsearch
     - nodebb-plugin-markdown
     - nodebb-plugin-mentions
     - nodebb-plugin-soundpack-default
     - nodebb-rewards-essentials
     - nodebb-widget-essentials
     - nodebb-widget-ns-stats
     - nodebb-widget-search-bar
     - nodebb-plugin-beep
     - nodebb-plugin-calendar
     - nodebb-plugin-canned-responses
     - nodebb-plugin-category-notifications
     - nodebb-plugin-desktop-notifications-v2mm
     - nodebb-plugin-dwnvtr
     - nodebb-plugin-emoji-apple
     - nodebb-plugin-emoji-extended
     - nodebb-plugin-emoji-one
     - nodebb-plugin-featured-threads
     - nodebb-plugin-featured-topics-extended
     - nodebb-plugin-highlights
     - nodebb-plugin-ignore-users
     - nodebb-plugin-important
     - nodebb-plugin-leaderboard
     - nodebb-plugin-newsletter
     - nodebb-plugin-ns-awards
     - nodebb-plugin-ns-custom-fields
     - nodebb-plugin-ns-embed
     - nodebb-plugin-ns-likes
     - nodebb-plugin-ns-points
     - nodebb-plugin-ns-utils
     - nodebb-plugin-poll
     - nodebb-plugin-postmentions
     - nodebb-plugin-question-and-answer
     - nodebb-plugin-reactions
     - nodebb-plugin-reputation-for-posting
     - nodebb-plugin-save-plugins
     - nodebb-plugin-slack-extended
     - nodebb-plugin-soundpack-aosp
     - nodebb-plugin-upvote-notifications
     - nodebb-plugin-view-votes

[baris]

This is fixed in https://github.com/NodeBB/NodeBB/commit/43f9c3224fa8cc67c12e7bca909c87fdf9112234, you can wait for 1.7.0 or disable nodebb-plugin-leaderboard until you update.

0 barisusakli committed to NodeBB/NodeBB

dont crash sortedSetIncryBy on redis if no callback is supplied

[btc]

Excellent thanks!