[nodebb-plugin-reactions] Reactions plugin for NodeBB

phenomlab

@zmih waiting for @Antosik I believe....

zmih

@phenomlab I tried to install it and error codes popped up. So, it's not working.

phenomlab

zmih Yes, there is a pending fork from @Antosik that is required before this will work.

<baris>

Published @nodebb/[email protected]

This includes the changes from @Antosik so it has a breaking change for themes. To add support in your custom theme include this where you want the reactions to show up.

<!-- IMPORT partials/topic/reactions.tpl -->

For example https://github.com/NodeBB/nodebb-theme-persona/commit/8cbad331ff9c8abe23e2a9a6d02d637857acbd2f

phenomlab

@baris Seems there's an issue with this. Once installed, it cannot be removed (comes up with an error in the admin page)

I'm also unable (it seems) to remove using npm remove from the CLI.

I'm using v2 of NodeBB in dev (not prod obviously).

<baris>

@phenomlab please open an issue on our gh, seems like an issue with that api route and scoped packages.

phenomlab

@baris Will do. Thanks

phenomlab

@baris Done - see https://github.com/NodeBB-Community/nodebb-plugin-reactions/issues/8

DownPW

@baris

How to install for test ?

I have test npm i @nodebb/nodebb-plugin-reactions but I have error :

npm i @nodebb/nodebb-plugin-reactions
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/nodebb-plugin-emoji
npm ERR!   nodebb-plugin-emoji@"4.0.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer nodebb-plugin-emoji@"^3.5.0" from @nodebb/[email protected]
npm ERR! node_modules/@nodebb/nodebb-plugin-reactions
npm ERR!   @nodebb/nodebb-plugin-reactions@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/nodebb/.npm/eresolve-report.txt for a full report.

crazycells

hi @baris , is the forked version published? I think on ACP, I can only see the old version of the plugin?

<baris>

Forked version is published as @nodebb/nodebb-plugin-reactions

phenomlab

@baris having tested this before, it doesn't seem to work and cannot be uninstalled. Any update on this please ?

<baris>

Uninstalling scoped packages from ACP is broken https://github.com/NodeBB/NodeBB/issues/10582.

You can uninstall from the CLI with npm uninstall @nodebb/nodebb-plugin-reactions

phenomlab

@baris that doesn't work either - at least, not when I tested it last.

EDIT: Just tried again and it's working from the CLI

phenomlab

@baris I now have this working in 1.19.7 - thanks

Tez

@DownPW Were you able to find a fix for this? Just ran into this issue as well:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/nodebb-plugin-emoji
npm ERR!   nodebb-plugin-emoji@"4.0.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer nodebb-plugin-emoji@"^2.2.0" from [email protected]
npm ERR! node_modules/nodebb-plugin-reactions
npm ERR!   nodebb-plugin-reactions@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/nodebb/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/nodebb/.npm/_logs/2022-05-24T19_48_05_893Z-debug-0.log

Normando

@Tez same here in nodeBB 2.0.1

<baris>

Please try with @nodebb/[email protected]

Normando

@baris thank you so much. Runs like a charm!

DownPW

@baris

I have this on Nodebb 3.2.1 and @nodebb/nodebb-plugin-reactions 1.0.2

An idea ?

EDIT:

Uninstall emoji plugins and reactions = idem
delete broswer cache= idem
incognito windows navigator = idem
Rebuild emoji = idem