[Solved] Using the Active Users in Thread

[trevor]

<div class="thread_active_users active-users inline-block"></div>
Does not work anymore where I have it positioned which is OUTSIDE the <!-- BEGIN posts -->. This has worked before, but now, IDK what was changed.
I believe I am missing something here...
It works when I put it within the <!-- BEGIN posts --> block.

[baris]

Are you on latest? Active users block shouldn't be inside the posts block.

[trevor]

Yessir, I'm on the latest. And it should be inside (or should I say within) the posts block.
This is how it works here on Lavender below the first post on the posts-bar.

[baris]

Ahh gotcha, make sure your tpl files have this check https://github.com/designcreateplay/NodeBB/blob/master/public/templates/topic.tpl#L157. Without that each post has a postbar underneath which causes the active users to stop working.

[trevor]

Ohhh okay, got it. Thanks @baris !
Well really what I am saying is that now I am forced to put the browsing users in the postbar, as opposed to before I was able to put it anywhere.

[baris]

That might be something we can fix by modifying the javascript code. The selector is probably using the postbar class too which is not really necessary.

[trevor]

-_-' Dang. Well that limits flexibility here.
I'll have to find that selector in the topic.js

[baris]

I will do it don't worry

[baris]

https://github.com/designcreateplay/NodeBB/commit/3fe9bdc24cf59eadfcd54107fda9be577dc6aab7 should do the trick.

1 barisusakli committed to designcreateplay/NodeBB

removed the postbar selector from activeusers

[trevor]

Works nicely! Thanks @baris