Client side script seems to not work on page change

frostzn

@baris Do you mean where I am adding it? If so, I'm adding to the custom Javascript area in the ACP. Should I add it somewhere else instead?

<baris>

@frostzn no that's fine that's how I tested it as well.

<baris>

You can add a console.log and see if it is getting triggered at all.

$(window).on('action:ajaxify.end', function(ev, data) {
    console.log('action:ajaxify.end');
    if(ajaxify.data.template.name !== 'login' && ajaxify.data.template.name !== 'register'){
        if (!app.user.uid || app.user.uid === 0) {
            ajaxify.go('login');
        } 
    }
});

frostzn

@baris It seems to trigger. I get the console. And if I do ('action:ajaxify.end'); It seems to work while getting the alert message as well.

<baris>

So it is always going into the action:ajaxify.end handler? Can you try the below and see if it works?

$(window).on('action:ajaxify.end', function(ev, data) {
    console.log('action:ajaxify.end');
    if(ajaxify.data.template.name !== 'login' && ajaxify.data.template.name !== 'register'){
        if (!app.user.uid || app.user.uid === 0) {
            $('#content, #footer').removeClass('ajaxifying');
            ajaxify.go('login');
        } 
    }
});

frostzn

@baris Hmm, that doesn't seem to do the trick either. It's a real headscratcher. Thank you so much for your time and effort by the way!

<baris>

No worries, is this a public site or are you testing on local?

frostzn

@baris I am testing locally currently

frostzn

I guess this could be local specific issue, I could try testing this on a test domain and see if it still runs into the same issue.

<baris>

Well I was testing locally as well and wasn't able to reproduce. For me everytime I try to navigate console.log('action:ajaxify.end'); gets executed and it sends me back to the login page.

frostzn

@baris That's curious. Perhaps I messed up while installing Nodebb or something of the like? As it appears to be just me experiencing this issue?

<baris>

You can always setup a new blank nodebb on latest version and test there to rule out anything else.

frostzn

@baris This specific function is currently on a mostly blank slate, which makes it more confusing as well. I've tried putting in an console log after each if statement as well and it all goes through. It even goes to the ajaxify.go('login') but that just seems to do nothing.

<baris>

Hmm, can you try putting some more console.logs in ajaxify.go there are some cases where that function will not do anything. For example if there is already an ajaxify in progress it returns early.

Maybe you are getting caught by the ajaxify timer which prevents quick ajaxifies. https://github.com/NodeBB/NodeBB/blob/master/public/src/ajaxify.js#L41-L43.

In that case try it on the develop branch. Looks like @julian fixed that on that branch https://github.com/NodeBB/NodeBB/commit/b4297cd8f065a94e7de5a3ad4b992e61c9234ca0

frostzn

@baris I'll try that! And let you know how it turns out!

frostzn

@baris I copied the the code from the 2nd link into my version of Nodebb and that fixed the issue! Seems like there must've been an already ajaxify in progress which killed ajaxify.go('login')

Thank you so much! The issue is resolved!

<baris>

@frostzn yeah that explains it, when you click to go to another page an ajaxify starts and when you try to call ajaxify.go('login') it is getting caught by that code because the previous one hasn't finished yet.

We will release 3.5.1 this week