Some incompatible plugins (GDPR/NTFY)

phenomlab

Thought I'd mention this before I forget...

GDPR section in ACP does not work on 3.2.x

admin.min.js?v=bs9hm958cba:87 Unable to load template: admin/plugins/gdpr
(anonymous) @ admin.min.js?v=bs9hm958cba:87
/assets/templates/admin/plugins/gdpr.js?_=1688632868491:1     Failed to load resource: net::ERR_FAILED
admin.min.js?v=bs9hm958cba:88 Uncaught (in promise) TypeError: _ is not a function
    at l (admin.min.js?v=bs9hm958cba:88:58099)
    at admin.min.js?v=bs9hm958cba:88:58955

EDIT - seems it "partially" works in the sense that it renders some data but needs to be made compatible with 3.2.x

NTFY plugin does not seem to work in terms of any admin settings (not sure if this was finished actually - I know @julian was looking at updating it to so we could run self-hosted versions)

admin.min.js?v=bs9hm958cba:87 Unable to load template: admin/plugins/ntfy
(anonymous) @ admin.min.js?v=bs9hm958cba:87
J @ admin.min.js?v=bs9hm958cba:135
fireWith @ admin.min.js?v=bs9hm958cba:135
Rn @ admin.min.js?v=bs9hm958cba:138
(anonymous) @ admin.min.js?v=bs9hm958cba:138
load (async)
send @ admin.min.js?v=bs9hm958cba:138
ajax @ admin.min.js?v=bs9hm958cba:138
ajaxify.loadTemplate @ admin.min.js?v=bs9hm958cba:87
(anonymous) @ admin.min.js?v=bs9hm958cba:88
f @ admin.min.js?v=bs9hm958cba:88
(anonymous) @ admin.min.js?v=bs9hm958cba:88
(anonymous) @ admin.min.js?v=bs9hm958cba:88
try @ admin.min.js?v=bs9hm958cba:88
o @ admin.min.js?v=bs9hm958cba:88
(anonymous) @ admin.min.js?v=bs9hm958cba:87
(anonymous) @ admin.min.js?v=bs9hm958cba:87
Promise.then (async)
g @ admin.min.js?v=bs9hm958cba:87
(anonymous) @ admin.min.js?v=bs9hm958cba:87
success @ admin.min.js?v=bs9hm958cba:87
J @ admin.min.js?v=bs9hm958cba:135
fireWith @ admin.min.js?v=bs9hm958cba:135
Rn @ admin.min.js?v=bs9hm958cba:138
(anonymous) @ admin.min.js?v=bs9hm958cba:138
load (async)
send @ admin.min.js?v=bs9hm958cba:138
ajax @ admin.min.js?v=bs9hm958cba:138
ajaxify.loadData @ admin.min.js?v=bs9hm958cba:87
ajaxify.go @ admin.min.js?v=bs9hm958cba:87
h @ admin.min.js?v=bs9hm958cba:87
(anonymous) @ admin.min.js?v=bs9hm958cba:87
dispatch @ admin.min.js?v=bs9hm958cba:135
nt.handle @ admin.min.js?v=bs9hm958cba:135
admin.min.js?v=bs9hm958cba:88 Uncaught (in promise) TypeError: _ is not a function
    at l (admin.min.js?v=bs9hm958cba:88:58099)
    at admin.min.js?v=bs9hm958cba:88:58955

julian

Thanks for letting me know! I'll add this to my to-do list for today.

I didn't think the ACP refresh would break old plugins I'll see if I can sort that out...

julian

@phenomlab Ah, the ntfy one is because that plugin doesn't actually have an admin page. The route handler was kept in by accident because it's part of the quickstart plugin

https://github.com/NodeBB/nodebb-plugin-ntfy/commit/b373439f9a906ae948b53818446a0bc5cc0579c3

julian

@phenomlab re: GDPR... turn off uBlock Origin?

I... don't know why this is problematic...

phenomlab

@julian said in Some incompatible plugins (GDPR/NTFY):

turn off uBlock Origin?

I would if it wasn't already disabled

julian

@phenomlab hmm, please check your dev tools... When I navigate to the ACP page for the GDPR plugin it loads fine. It just doesn't load when I access it via the menu.

When I inspect the network tab it says the request was blocked by an extension. For me it's uBlock

phenomlab

@julian Yes, it "works" if you access the URL directly in the browser, but the plugin needs to be made compliant with 3.2.0 as it's still using the legacy settings as far as I see.

This is what I see in the console

The FetchEvent for "https://sudonix.org/assets/templates/admin/plugins/gdpr.js?_=1688980410146" resulted in a network error response: the promise was rejected.
service-worker.js:14     Uncaught (in promise) TypeError: Failed to fetch
    at service-worker.js:14:11
admin.min.js?v=467arndc44n:87 Unable to load template: admin/plugins/gdpr
(anonymous) @ admin.min.js?v=467arndc44n:87
/assets/templates/admin/plugins/gdpr.js?_=1688980410146:1     Failed to load resource: net::ERR_FAILED
admin.min.js?v=467arndc44n:88 Uncaught (in promise) TypeError: _ is not a function
    at l (admin.min.js?v=467arndc44n:88:58099)
    at admin.min.js?v=467arndc44n:88:58955

julian

@phenomlab v2.0.0 of the GDPR plugin has been published with a revamped ACP page conforming to the latest design as per @baris

I still can't speak to the error you're seeing as the page loads fine (even with the old design) without errors on my end.

phenomlab

@julian ok. Thanks very much.

phenomlab

@julian said in Some incompatible plugins (GDPR/NTFY):

the ntfy one is because that plugin doesn't actually have an admin page

I thought the intention was to have a settings page in the ACP to allow self-hosting?

https://community.nodebb.org/topic/17089/ntfy-nodebb?_=1689159596942

More and more of my forum users are switching to this more modern approach, and it would be good to have better control over it.

julian

@phenomlab yes, it makes sense, although I haven't had the time to implement that yet.

phenomlab

@julian No rush - just good to know it's still on the map