Action event (client side) for creating and updating posts

phenomlab

Hi. I'm working on a plugin that executes code client side. As a result, I need it to trigger when a post is created, updated, and saved.

Are there any existing action statements I can use?

Thanks

<baris>

I think this covers all those cases https://github.com/NodeBB/nodebb-plugin-markdown/blob/master/public/js/client.js#L334

  $(window).on('action:posts.loaded action:topic.loaded action:posts.edited', function () {
    
  });

phenomlab

@baris perfect. Thanks

phenomlab

@baris is there a client event for post created ?

<baris>

action:posts.loaded should fire when you make new posts as well

phenomlab

@baris thanks

phenomlab

@baris is there a similar set for chat ? I have action:chat.loaded working, but nothing renders when a new chat message is added unless I reload the page. I'm thinking of something like action:chat.updated ?

<baris>

Try

hooks.fire('action:chat.received', {
	messageEl: newMessage,
});

phenomlab

@baris said in Action event (client side) for creating and updating posts:

action:chat.received

thanks

phenomlab

@baris

action:chat.received

Doesn't seem to work - any ideas ?

Thanks

<baris>

Is the hook not firing when new chat messages arrive?

phenomlab

@baris No - or when sent.

Essentially, it's this

    $(window).on('action:chat.loaded', function(data) {
    $(document).ready(function() {
    previewLinks()
    });
    });
    
    $(window).on('action:chat.received', function(data) {
    $(document).ready(function() {
    previewLinks()
    });
    });

The chat.loaded works fine, but chat.received doesn't seem to do anything.

<baris>

$(window).on('action:chat.received', function(data) {
    $(document).ready(function() {
      console.log('hook triggered'); 
      previewLinks()
    });
});

I guess check if the hook is triggered with a console.log, if it's triggered gotto take a look in previewLinks to see why it's not working.

phenomlab

@baris Seems it does trigger according to the console log, although the resultant output is unexpected in the sense that it works fine for posts, but not for chat.

In this use case, I am polling an Open Graph proxy server, and getting the below in chat, but not in posts where it works fine

Access to fetch from origin [origin] has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

Equally, on chat reload (F5), it works fine.

phenomlab

@baris fixed - I am calling variable url which it appears should be encoded, so

                $.ajax({
                    url: proxy + "/ogproxy?url=" + encodeURIComponent(url),
                    method: "GET",
                    headers: {
                        'X-Api-Key': apiKey
                    },

phenomlab

@baris just circling back on this thread. I'm working on my threading applet for chat messages now that the topic/post version is mature, and everything is working on load, but not for the below

$(window).on('action:chat.received', function(data) {
    	$(document).ready(function() { 
    	    console.log('hook triggered'); 
        threadedChat();
});
});

The console message does not fire when new data/posts are being added to the chat window.

Any thoughts ?

This one works fine on load

$(window).on('action:chat.loaded', function(data) {
    	$(document).ready(function() { 
        threadedChat();
});
});

<baris>

@phenomlab I tested the below and it is firing when I send messages.

$(window).on('action:chat.received', function(data) {
	    console.log('hook triggered'); 
});

That hook is correct https://github.com/NodeBB/NodeBB/blob/master/public/src/client/chats/messages.js#L107 so there must be another issue if you are not seeing the logs.

phenomlab

@baris said in Action event (client side) for creating and updating posts:

I tested the below and it is firing when I send messages.

Ok, but does it fire when older messages are being pulled into the chat? Find a chat session with a long thread and scroll up to load more and see if it fires then.

phenomlab

@baris this doesn't work either when older messages are pulled into the view

$(window).on('action:chat.loaded', function(data) {
    	$(document).ready(function() {
        console.log('hook triggered'); 
        threadedChat();
});
});

<baris>

Yeah there doesn't seem to be a hook that fires when messages are added due to scrolling up. I will add a hook that fires whenever new messages are added to dom.