Tenor GIF

phenomlab

@Sampo2910 In my testing, I get the same issue.

<baris>

Seems to work on this forum, what version of nodebb and plugin are you using?

phenomlab

@baris Both the NPM version, and directly from GitHub. @Sampo2910 is on the latest version, whilst I tested on 2.2.5 - we both get the same results.

<baris>

This forum is running 2.3.1 and [email protected].

What result do you get when you load the tenor url directly https://api.tenor.com/v1/search?q=Happy&key=<tenor_key> ?

phenomlab

@baris said in Tenor GIF:

https://api.tenor.com/v1/search?q=Happy&key

{"code": 16, "error": "API key invalid."}

Which is odd, because the key is in fact valid. Does the plugin work with v1 of the API, or v2 ? I think v1 is deprecated.

<baris>

The plugin is using v1, maybe our key is for v1 as well. https://github.com/julianlam/nodebb-plugin-tenor-gif/blob/master/library.js#L59

phenomlab

@baris That makes sense. Can the plugin be adapted to also support v2 ?

<baris>

I don't see v2 api docs here https://tenor.com/gifapi/documentation#quickstart-search. Where did you see v1 is deprecated?

phenomlab

@baris have a look at https://developers.google.com/tenor/guides/migrate-from-v1#update-v2-domains

The issue here is that the API generator only creates v2, and not v1.

"Go to the docs" is the v2 documentation.

<baris>

For reference https://github.com/julianlam/nodebb-plugin-tenor-gif/issues/23

phenomlab

@baris @julian any update here please ?

EDIT - just tried it again, and it works

Thanks

Sampo2910

@phenomlab @julian @baris

Also works for me now Nice Job. Thx.

julian

Ah, sorry I didn't update the thread! Yes, I did update the plugin to use v2 of the Tenor API last week

As a bonus, it now also shows some trending gifs on initial load (or empty query)

crazycells

@julian said in Tenor GIF:

Ah, sorry I didn't update the thread! Yes, I did update the plugin to use v2 of the Tenor API last week

As a bonus, it now also shows some trending gifs on initial load (or empty query)

it does not work here in this forum... FYI...

Screen Shot 2022-08-21 at 16.24.20.png