Images broken on notification emails

phenomlab

Since 1.16.12 and now on 1.17.x, the images in notification emails seem to be broken. Had anyone else noticed this ?

phenomlab

For a bit of clarity, it seems that the img-src is missing from the HTML being rendered

<baris>

Is this setting turned on in the ACP?

It is located at /admin/settings/email#email-notification-settings. And it removes all images from notification emails.

phenomlab

@baris no. This is the first setting I checked.

<baris>

Which email notification is this? I couldn't find the text has posted a new topic called. We have translation string for "user_posted_topic": "<strong>%1</strong> has posted a new topic: <strong>%2</strong>"

phenomlab

@baris it's the "New Topic in {tag}". I don't recall changing anything in terms of translation, but may have done so without realising.

phenomlab

@baris I think I tracked this down - looks like it comes from https://github.com/NodeBB/nodebb-plugin-category-notifications#readme which I have installed.

<baris>

I think this should be fixed in https://github.com/NodeBB/nodebb-plugin-category-notifications/commit/c70e9d2940fd93089951db90a3eb9447439a7871