[nodebb-plugin-emoji-extended] Emoji Extended

frissdiegurke

@tedr56
Any errors within js-console?
Does the textarea get wrapped by a div of class textcomplete-wrapper?
If so is it still there if no other plugin that create suggestions like nodebb-plugin-mentions is enabled?

julian

Hmm... @tedr56 -- cleared cache?

Ted

@julian Yes, cleared, as aslways

@frissdiegurke nodebb-plugin-mentions disabled doesn't change anything.

textcomplete-wrapper seems to be there : PasteBin

For Js errors, I couldn't tell. There is :

Connextion with ws://kos.ddns.info/socket.io/1/websocket/J4B98mfcQ2sf70yhY-OF has been interupted during page loading from socket.io.js:2

Using « Mutation Events » is obsolete. Use « MutationObserver » instead. from nodebb.min.js(2)

Using « getPreventDefault() » is obsolete. Use « defaultPrevented » instead. from nodebb.min.js(2)

When accessing composer :

An empty string has been transmited to « getElementById() » coming from nodebb.min.js(1)

Errors are translated. Appearing in french in my Firefox

Ted

I must say the emojis are parsed and decoded well.

Just the suggestions are not working.

julian

@tedr56 Can you try deleting nodebb.min.js from /public/src?

Ted

@julian said:

@tedr56 Can you try deleting nodebb.min.js from /public/src?

And you win again!

Did the trick.

What is this file? I saw it also making trouble in the shoutbox topic.

Is it so insignificant to stay deleted?

julian

Hahah @tedr56 That file is a "minified" version of all of the javascript files. We load perhaps 15-20 separate files (more if there are plugins, and emoji uses 1) normally, and we squish 'em all down into one tiny file in production mode.

Sometimes things go awry and the file doesn't get compiled properly, as seems to be the case here.

Ted

@julian That makes much more sense now. Thanks.

manuel

Can you add a button to insert emoticons in a easy way and to display a list of all available emoji with relative mappings?

frissdiegurke

@manuel Would get a long list... will take a look at this in a few days If you need a list for yourself you may look here

julian

@manuel Perhaps @frissdiegurke can add a "sample" listing (~10 icons) to the "Help" tab in the composer, and a link to the full list? Let me put together a pull request for him...

manuel

@julian +1 but it would be nice to have a toolbar button for lazy users

frissdiegurke

late enough to add some features

Version 0.2.3-3:

Added a help-message.
Added zoom, size configurable via ACP

@julian Anything done with the BONUS POINT of #1409 yet? Will it be dropdown-able?

Planned are:

dropdown to add emoji
remove : from emoji-title, add : to emoji-alt tags therefor copy+paste will not remove them
(figure out better way to exclude code-elements for textcomplete (current way is markdown-support only))
at least deactivate exclusion when markdown-plugin isn't enabled

Any other suggestions?

julian

@frissdiegurke shouldn't be too much work to add the hook in for you to add buttons to the composer toolbar

Let me make a new issue for it... #1444

Xiph

Activating the plugin crashes NodeBB with the following error:
error: Object #<Object> has no method 'persistOnEmpty' TypeError: Object #<Object> has no method 'persistOnEmpty' at resetConfigIfEmpty (C:\nodebb\node_modules\nodebb-plugin-emoji-extended\index.js:1:850) at Object.module.exports.configDefaults (C:\nodebb\node_modules\nodebb-plugin-emoji-extended\index.js:1: 1072) at C:\nodebb\src\plugins.js:347:23 at C:\nodebb\node_modules\async\lib\async.js:111:13 at Array.forEach (native) at _each (C:\nodebb\node_modules\async\lib\async.js:32:24) at Object.async.each (C:\nodebb\node_modules\async\lib\async.js:110:9) at Object.Plugins.fireHook (C:\nodebb\src\plugins.js:345:12) at C:\nodebb\src\plugins.js:400:15 at C:\nodebb\src\plugins.js:100:5 info: [app] Shutdown (SIGTERM/SIGINT) Initialised. info: [app] Database connection closed. info: [app] Shutdown complete.

EDIT: I'd add newlines to the above code block, but that just breaks it =P

frissdiegurke

@Xiph should be fixed now, please update to 0.2.4-2 (will reset settings), thanks for reporting

frissdiegurke

I've just added a small client-side API to provide functions like adding the textcomplete to other fields.
please update to 0.2.5-3 in order to allow other plugins/scripts to use this.

a_5mith

Bug time, haven't updated yet though. Go into your settings, turn on open external urls in a new window, try and click an emote in the drop down. Still parses, but opens a blank tab, even though it's an internal URL.

frissdiegurke

@a_5mith you mean the "Use Outgoing Links Warning Page"? I don't find any option like you mentioned, but the warning page causes problems...

@baris @psychobunny @julian would someone of you like to tell me what this option does or where the relevant part can be found within the src? would save much work thought.
I guess this may be best fixed within core by not handling plain a-tags without href attribute as external links.
If I'm right this causes the problem(s)

<baris>

That setting is supposed to show a warning page when you click a link that goes outside of nodebb. The relevant code is in ajaxify.js i think around here

NodeBB/public/src/ajaxify.js at master · NodeBB/NodeBB

Node.js based forum software built for the modern web - NodeBB/public/src/ajaxify.js at master · NodeBB/NodeBB

GitHub (github.com)