[nodebb-plugin-emoji-extended] Emoji Extended
-
@julian said:
LOL! Can you do it for regular emoji too? Much obliged
(p.s. Mentions plugins has been updated to use the new textcomplete version too)
Works great! 
didn't test it with
:+1:^^seems like encoded ULIs get filtered to 404 o_O I guess this needs to be fixed within core...
and one other issue with
:+1:I'll need to fix is that the regex doesn't match any more after typing:+
With "regular emoji" you mean the plugin right? Not
:), etc. In the first case I'd say the plugin may be taken down and I could remove the 'extended', because the reason for two different plugins has been the mapping of common smileys that now can be removed via settings. In the second case I think it's a bit overheaded because the dropdown would to often. -
seems like encoded ULIs get filtered to 404 o_O I guess this needs to be fixed within core...
-
@frissdiegurke Take a look at this
autofill.js:I'm listening for the client-side event
action:composer.loaded, which is better than adding a new textcompleteonfocus -
I'm thinking of bundling emoji-extended with all new NodeBB installs... :shipit:
Two issues however:
- Emoji autocomplete does not seem to work when editing a post (my post before this one might help with that)
- Typing
:triggers autocomplete even at the end of words (perhaps it should check for a word boundary)- It also means autocomplete triggers when I am typing the end of another emoji:
:shipit: <-- autocomplete triggers
- It also means autocomplete triggers when I am typing the end of another emoji:
-
@julian First issue should be fixed already since I've used your solution like 10min after your post
.
Second issue already noticed, will be fixed soon... (if there would be no 404 Error on this) to bundling New issue figured out writing this post: some mappings (just some because of other reasons) need
\s|$after key, so I can't write sth. like:P.^^ -
Hey guys,
I'm testing this plugin. Sounds great but I can't make the suggestion scroll list appears like on this forum.
I'm having the default options: Max text-completion : 8 . Min text-completion : 0. Not overriding emoji-skype.
Any advice on this?
-
@tedr56
Any errors within js-console?
Does the textarea get wrapped by a div of classtextcomplete-wrapper?
If so is it still there if no other plugin that create suggestions likenodebb-plugin-mentionsis enabled? -
@julian Yes, cleared, as aslways
@frissdiegurke nodebb-plugin-mentions disabled doesn't change anything.
textcomplete-wrapperseems to be there : PasteBinFor Js errors, I couldn't tell. There is :
Connextion with ws://kos.ddns.info/socket.io/1/websocket/J4B98mfcQ2sf70yhY-OF has been interupted during page loadingfrom socket.io.js:2Using « Mutation Events » is obsolete. Use « MutationObserver » instead.from nodebb.min.js(2)Using « getPreventDefault() » is obsolete. Use « defaultPrevented » instead.from nodebb.min.js(2)When accessing composer :
An empty string has been transmited to « getElementById() »coming from nodebb.min.js(1)Errors are translated. Appearing in french in my Firefox
-
I must say the emojis are parsed and decoded well.
Just the suggestions are not working.
-
Hahah @tedr56 That file is a "minified" version of all of the javascript files. We load perhaps 15-20 separate files (more if there are plugins, and emoji uses 1) normally, and we squish 'em all down into one tiny file in production mode.
Sometimes things go awry and the file doesn't get compiled properly, as seems to be the case here.
-
-
late enough to add some features
Version 0.2.3-3:
- Added a help-message.
- Added zoom, size configurable via ACP
@julian Anything done with the BONUS POINT of #1409 yet? Will it be dropdown-able?
Planned are:
- dropdown to add emoji
- remove
:from emoji-title, add:to emoji-alt tags therefor copy+paste will not remove them - (figure out better way to exclude code-elements for textcomplete (current way is markdown-support only))
at least deactivate exclusion when markdown-plugin isn't enabled
Any other suggestions?
