Possible bug? Deleted Posts listed

PitaJ

@jongarrison it's expected behavior

julian

Intentional. If we hid them from the list, pagination would get all messed up (long story).

To remove the post completely, purge.

jongarrison

Ok, good to know.

psychobunny

Actually, @julian (actually @baris, likely) can I get the long story for this one? I feel like I already know the reason why, but not sure why we can't height: 0; overflow: hidden for that.

I'm probably going to get an answer that makes me facepalm but I might as well ask.

EDIT: my CSS recommendation is only for users who aren't able to restore that topic of course

PitaJ

@psychobunny you would actually need

.category > ul > li.deleted {
  min-height: 0;
  height: 0;
  padding: 0;
  overflow: hidden;
}

psychobunny

My thoughts exactly. Better than having a "this is deleted!" post.

@baris pinging you for your two cents

Henry Wright

@psychobunny said:

but not sure why we can't height: 0; overflow: hidden for that.

My SEO buzzer is going off! Would Google frown on that?

<baris>

@psychobunny we display them so we don't have pages with missing topics when you use pagination.

julian

That. Because we store the deleted state of a topic in the topic hash itself, and individual users can or cannot see the topic/post depending on their privilege level, we have to filter the topics after retrieving the tids from the database, and if the user happens to not be able to see some of them, then a page with 20 topics suddenly only has 18 (or less).

Basically, this was a non-issue until we got spammed, and then when we deleted 20-40 spam topics, then entire categories would simply be empty because the "page" had only deleted topics.

jongarrison

I think I understand the reasons related to scalability for leaving the deleted posts, but how about some sort of throttled auto purge functionality? This way a NodeBB site wouldn't be over taxed by a massive number of deletions, but would still have deleted posts removed from view in a timely way.

wktang

@julian said in Possible bug? Deleted Posts listed:

if the user happens to not be able to see some of them, then a page with 20 topics suddenly only has 18

Does this apply to infinite scrolling as well?

julian

@wktang Yes, this does apply to IS as well.