nodebb-plugin-youtube-lite creating video frames for regular links?

SimonQ

@a_5mith I recently updated to the latest version of nodebb (v0.7.3 as of this writing) and noticed the youtube lite plugin changes all my links to video panels instead of just youtube links.

This is my page at the moment that's causing this issue: here

As you can see all my links are embedded Youtube videos, even the ones that are not youtube links.

Is this something on my end or a mini bug from updating to v0.7.3?

julian

@SimonQ They looks like Youtube Links to me, actually. Did you mean you wanted them embedded?

SimonQ

@julian I deactivated the plugin just now because I could not stand it. I meant to say they were all embedded before (even the links that were not youtube links).

I reactivated it again to show you what I mean.

julian

@SimonQ I think this is what the plugin is meant to do... if you want to keep them as links, you could disable the plugin, unless I'm misunderstanding the effect you are trying to achieve...

SimonQ

@julian Previously the plugin would embed only Youtube links. Regular links (i.e. www.google.ca) would work as the standard links users can click and be redirected to another page like this.

Since updating to v0.7.3, that feature seems to have been broken I believe.

julian

Oh Yes, that is definitely a bug!

hukadan

I filled a bug report concerning this issue https://github.com/a5mith/nodebb-plugin-youtube-lite/issues/15

You can come back to a working plugin by reverting the linked commit (at least it worked for me).

SimonQ

@hukadan How do you revert back to the linked commit?

julian

Not sure of the version from npm... but you can manually install the plugin thusly:

$ cd node_modules/
$ rm -rf nodebb-plugin-youtube-lite
$ git clone https://github.com/a5mith/nodebb-plugin-youtube-lite.git
$ cd nodebb-plugin-youtube-lite
$ git revert aee6769d4025ad4d87bc4e2121a9dd5dc890ecc5
$ cd ../..
$ ./nodebb restart

This is just a temporary fix until @a_5mith fixes the issue. Once he fixes it, you can rm -rf node_modules/nodebb-plugin-youtube-lite and re-install the plugin via the plugins page.

a_5mith

Reproduced the issue. Bloody regex. Will see if it's easy to fix.

a_5mith

This is now fixed. Update the plugin to latest 0.4.2.

SimonQ

@a_5mith Thanks for the quick fix. Maybe it's me but, now the youtube links are not getting embedded? I reloaded the plugin and checked that I have the up to date version.

a_5mith

Restart your forum. Then clear cache.

SimonQ

@a_5mith I restarted my forums, then cleared my browser cache if that's what you were referring to. I'm still getting the same results? Or did I misinterpret what clearing the cache meant.

a_5mith

Ah, my mistake, I forgot about the rel=nofollow that's now a thing. Give me a moment to add that back in. I completely rewrote the regex for the update.

It worked for me because I have nofollow turned off.

a_5mith

Can you try 0.4.3 and let me know how that goes. I think I've covered most possible links. Same as before, restart forum, then Ctrl + F5 the page to refresh cache.

There's two that won't work, but they'll be quite rare. If a URL ends with &feature=related then it won't embed. It will if it's the first parameter in the URL (?feature=related&etc)

The other links that don't work are links that the user removes the www. from. If it's pasted straight from youtube, it'll work.

I will take a further look at it at some point, but it should now capture most URLs. Fingers crossed.

SimonQ

@a_5mith Still not working it seems. I copy the link from youtube through the share box like this:
https://youtu.be/H_Djd_teJVw

julian

Can you paste the post's markdown for @a_5mith to debug?

SimonQ

@julian @a_5mith these a few of the markdowns that are under the youtube "shared" tab links.

#### Day 7 Finals
[Day 7 Finals](https://youtu.be/BtUjV47ownU)

#### Day 7 Finals MD M. Ahsan/Hendra Setiawan vs Liu Xiaolong/Zihan Qiu 
[Day 7 Finals MD M. Ahsan/Hendra Setiawan vs Liu Xiaolong/Zihan Qiu](https://youtu.be/H_Djd_teJVw)

#### Day 7 Finals MS Lee Chong Wei vs Chen Long
[Day 7 Finals MS Lee Chong Wei vs Chen Long](https://youtu.be/DHldrixwTFw)

#### Day 7 Finals XD Liu Cheng/Bao Yixin vs Zhang Nan/Zhao Yunlei
[Day 7 Finals XD Liu Cheng/Bao Yixin vs Zhang Nan/Zhao Yunlei](https://youtu.be/a6ZdVjmzZMo)

#### Day 7 Finals WD Zhao Yunlei/Tian Qing vs Christina Ped./Kamila R. Juhl
[Day 7 Finals WD Zhao Yunlei/Tian Qing vs Christina Ped./Kamila R. Juhl](https://youtu.be/TUhFCkLw7U4)

#### Day 7 Finals WS Carolina Marin vs Saina Nehwal
[Day 7 Finals WS Carolina Marin vs Saina Nehwal](https://youtu.be/OAxIy8Hw6_k)

a_5mith

Does it work if you just paste the link directly? Without markdown.