[nodebb-plugin-emailer-local] Local email plugin

psychobunny

nice, congrats on your first plugin!

julian

Looks good, thanks @barveyhirdman! Congrats on your first plugin

BarveyHirdman

One thing I forgot. Currently the SMTP password is a text field as I couldn't get its value when I used password type. Is there any trick?

psychobunny

@BarveyHirdman, I just updated settings.js to handle password fields. Update to this commit and it should work, I tested with your plugin

BarveyHirdman

@psychobunny Thank you, pushed the fixed version.

Edit: Forgot to publish new version to npm. Still need to get used to this.

julian

@BarveyHirdman said:

Still need to get used to this.

Tell me about it...

$ npm version {newversion} && git push && git push --tags && npm publish

BarveyHirdman

@julian guess who's going to steal this.

julian

Don't forget grep version package.json to find the current version

trevor

Thanks @barveyhirdman

BarveyHirdman

Started creating service support (Gmail, Hotmail, anything Nodemailer can handle)

julian

Mmm... that raises a good question -- should you create a new plugin for each of those? Or maybe a "meta" plugin for the whole lot?

Seems a bit weird to put Gmail and Hotmail capability into a supposedly "local" plugin.

So I imagine, either:

Rename nodebb-plugin-emailer-local to nodebb-plugin-emailer-nodemailer, or
Create a new plugin nodebb-plugin-emailer-webmail, or something?

BarveyHirdman

@julian yeah actually that makes sense. I'm not sure what would be the more reasonable path.

I'll go with a separate service pack named nodebb-plugin-emailer-nodemailer and leave local alone.
Maybe nodebb-plugin-nodemailer?

Leonardo Galani

Hi,, tried to install it.. when i hit the link on the menu.. the address doesnt exist...

http://xxxxxx/admin/plugins/emailer-smtp

finid

@Leonardo Galani

This image shows the actual message the system gives, and it happens in almost all the plugins I have installed.

Leonardo Galani

Yep.. thats it planner.. i saw the other topic... gonna wait

psychobunny

I missed this thread

Maybe nodebb-plugin-nodemailer?

This. I don't think you should duplicate code across several plugins. It would be perfect to be able to configure either local SMTP or gmail/etc from one page, no need to create multiple plugins. I feel like this is so important that it should really be core. If you like @BarveyHirdman submit a PR maybe and get this in

finid

@psychobunny

Yep, I agree. Since it's fundamental to the running of a website, it should be core. If somebody does not want to use a local mail service, they she/he can use a 3rd-party service by installing a plugin.

Chris

I think it can stay as a plugin but come bundled like some of the others come. Nothing wrong with that.

trevor

@planner said:

@psychobunny

Yep, I agree. Since it's fundamental to the running of a website, it should be core. If somebody does not want to use a local mail service, they she/he can use a 3rd-party service by installing a plugin.

I really pushed the issue for a local smtp mailer being in the core, but was rejected for whatever reason. It shouldn't be a plugin at all. Out of all of the forums I've used, the local mailer was always built in the core for ease of use and keeps things simple. Can someone explain to me further what advantage making the local mailer would be? I don't seem to understand.

Funny thing is, all this time I've been using NodeBB, I STILL have no mail server connected with it because I'm confused here. From core to plugin, and now we have this...

finid

@Chris

Isn't that just giving site admins one more task to do, on top of countless others that they have on their hands.