NodeBB Vanilla - Small bug

[trevor]

Add this to the header.less in Vanilla

#notif_dropdown:before {
	content: '\f0a2';
	display: inline-block;
	font-family: FontAwesome;
	font-style: normal;
	font-weight: normal;
	line-height: 1;
}

When using FontAwesome without the specific fa class, you could most certainly break the style with inconsistencies.

When you're manually manipulating font icons using your own class with :before you should always reset the position by using:

font-style: normal;
font-weight: normal;
line-height: 1;

Exceptions on when you're styling the icon itself

In this case, when you hover on the notification icon AND there's a background added to it, it doesn't match with the other icons beside it and bleeds out the header by a single pixel.

[julian]

Wow, good work @trevor, and good eye. Something like that is pretty damn easy to miss.

Tag @psychobunny

[trevor]

Yeah it annoyed me as I noticed it and did almost everything else to fix it and failed for 3 hours, two days later I took another shot and it was like a duh moment.