Embedding 3D models in posts

[arasbm]

I am looking for a way to be able to embed a 3D model in NodeBB post. For example, the embed code you get from sketchfab looks like this:

<iframe width="640" height="480" src="https://sketchfab.com/models/51426b30bd7848138617bf1e7f212793/embed" frameborder="0" allowfullscreen mozallowfullscreen="true" webkitallowfullscreen="true" onmousewheel=""></iframe>

I dont think that code can be used directly inside a post. Although, for some reason it seems to work in my local dev instance.

Do I need to write a plugin to embed sketchfab 3D models?

[baris]

Something like https://github.com/psychobunny/nodebb-plugin-youtube/blob/master/library.js should work no?

[arasbm]

Yeah that makes sense. I just wanted to double check to make sure there isnt a way to do this already. I forked it, and will make that plugin asap. Thanks.

[julian]

@arasbm It sounds familiar... I think @tedr56 made the same plugin:

GitHub - tedr56/nodebb-plugin-sketchfab

Contribute to tedr56/nodebb-plugin-sketchfab development by creating an account on GitHub.

GitHub (github.com)

[arasbm]

@julian yes, I think that is exactly what I was looking for, will give it a try. Thanks!

[PitaJ]

@arasbm A nodebb-plugin-iframe, I guess? That sounds really useful.

[a_5mith]

@pitaj I would advise against letting just anyone use iFrames on your site. Potential for all sorts of issues. Much better to either link to the site, or have a plugin that handles a specific service.

[PitaJ]

@a_5mith

The same origin policy would protect against most of that stuff, but I agree. Maybe having a url filter of some sort testing it against a whitelisted database which could be configure by the admins.