[nodebb-plugin-github-embed] GitHub Issue Embedding
-
@julian lol, got the last 3 notifications (1h ago) delivered with this one ^^ no clue why
-
@julian And I get 502 on accessing https://community.nodebb.org/notifications may there be some kind of bug?
-
@julian You're welcome it's always nice to look into other peoples code, if it's well-structured
And to test your plugin once more: #1413 -
gh#1337
Just testing this.
-
It's mostly a aesthetic choice. I'm not a fan of plugins that replace certain keywords with an inline object (take for example, youtube videos). That example is less of a problem, but I like being able to reference an issue in the middle of a sentence... a la:
Take a look at gh#256, that's where we solved that bug
^ No interruption of flow, and the referenced issue is at the bottom for you to check out if you want.
-
I'll disagree with both of you and suggest that the output be a popup similar to @Schamper's plugin. On mobile, just links to the actual issue. When I mention gh#123 it should be a link, at the very least. Just some ideas
EDIT: Scratch all of the above, you guys just gave me a great idea for a hook. Will get back to this later
-
@psychobunny reading the title of the issue you used in your example took 4 attempts to make any sense... kept thinking I was reading words over and over again like a child that reads the same line twice.
-
@a_5mith said:
@psychobunny reading the title of the issue you used in your example took 4 attempts to make any sense... kept thinking I was reading words over and over again like a child that reads the same line twice.
And the best part?
I don't even need it anymore
-
@julian Is it possible to update this plugin to work with private repositories? I have a private forum for a group of developers I am working with to create and indie game and it would great to be able to use this but our repo must be private for obvious reasons.
-
Hi @Chris-Rabuse -- private repositories are hidden behind secure API endpoints that require a client ID and secret to access. You can generate one tied to your account in the GitHub account settings. I use my personal GitHub account, but I believe an organization works too.
It looks something like this:
If you register for an id/secret pair and put it into the GitHub Embed settings, it should allow the plugin to read/show private issues.
Keep in mind that this also means unprivileged users on your forum could also use the short codes to retrieve private issue data, so caveat emptor