Composer tpl editing

julian

Are you using a copy of lavender? You have to make sure that all references to lavender have been renamed in the following files:

package.json
plugin.json
theme.json

Otherwise, it will conflict with the existing lavender install, and unpredictable things may occur, like what you're experiencing here.

Giorgio Chiodi

I'm using a modified vanilla theme

Giorgio Chiodi

Actually, I'm using vanilla, but modifying the plugin.json spectaculartly crashes nodebb.
Right now plugin.json is pointing to nodebb-theme-lavender.
If I switch to nodebb-theme-odv2 (my custom theme) nodebb won't even start.

@julian @psychobunny

julian

Because there are two themes identifying themselves as lavender, this is most likely the cause of your problems.

Please make sure the references are explicit, and your custom theme identifies itself under the same name as its folder name.

Giorgio Chiodi

@julian

this is my package.json


{
  "name": "nodebb-theme-odv2",
  "version": "0.0.30",
  "description": "OD Theme for NodeBB",
  "main": "theme.less",
  "repository": {
    "type": "git",
    "url": ""
  },
  "keywords": [
    "nodebb",
    "theme",
    "themes"
  ],
  "author": {
    "name": "",
    "email": ""
  },
  "license": "BSD-2-Clause",
  "bugs": {
    "url": ""
  },
  "peerDependencies": {
    "nodebb-theme-vanilla": "~0.0.18"
  },
  "readme": "",
  "readmeFilename": "README.md",
  "homepage": "",
  "_id": "",
  "_shasum": "",
  "_from": "",
  "_resolved": ""
}

plugin.json

{
	"id": "nodebb-theme-lavender",
	"library": "./lib/theme.js",
	"hooks": [
		{
			"hook": "filter:widgets.getAreas", "method": "defineWidgetAreas", "callbacked": true
		}
	],
	"staticDirs": {
		"vendor": "static/vendor"
	},
	"scripts": [
		"static/lib/lavender.js"
	]
}

and theme.json

{
    "id": "nodebb-theme-odv2",
    "name": "OD Theme for NodeBB",
    "description": "-",
    "url": "-",
    "screenshot": "screenshot.png",
    "templates": "templates",
    "staticDir": "static"
}

psychobunny

Seems like you forgot to rename your plugin.json, it still is showing "id": "nodebb-theme-lavender",

julian

I've fixed that for you, @Giorgio-Chiodi

Hopefully that does it.

Giorgio Chiodi

@Giorgio-Chiodi said:

],
"staticDirs": {
    "vendor": "static/vendor"
},
"scripts": [
    "static/lib/lavender.js"
]

}

Ah ok, I see you - @julian removed this part?
I couldn't edit the ID without breaking the install, otherwise.

],
"staticDirs": {
    "vendor": "static/vendor"
},
"scripts": [
    "static/lib/lavender.js"
]

Giorgio Chiodi

@Giorgio-Chiodi @julian @psychobunny @trevor

Let me explain why I'm trying to edit it, since this might interest others as well.

When I edit or reply on my smartphone, most of the vertical space is used up by the formatting bar and preview / help bar.
This is what I did, it's far from not perfect, but it does the job until I'll do a major theme redesign.

The one thing that I don't understand is how to "grow" the textarea all the way to the button, to maximize typing space

This is the "wide" view, with all the toolbars in place - notice the repositioned icons

This is the XS mode - notice the buttons with just the icons - no text

Finally, this is the view from my phone, in portrait view - notice all the wasted space under the textarea

julian

The last picture is trickest, since you have to account for the keyboard across all devices, and browsers don't really have a good way to see virtual keyboard state, etc...

The check and X for the buttons is a good idea!