Gotchas for v0.5.0

[julian]

Another minor version, another slew of breaking changes

Keep in mind v0.4.3 was released today, so v0.5.0 is 2-4 weeks out.

Here's v0.5.0's list of breaking changes:

• The privileges system got a bit of a rewrite (+ UI revamp!), and almost all privileges have been renamed (issue #933):
  • Migration Steps
  • +r has become read
  • +w has split into topics:create and topics:reply
  • g+r has become groups:read
  • g+w has split into groups:topics:create and groups:topics:reply
  • This means all forked themes with custom templates should check their files and rename privileges as necessary
• A new ephemeral group "guests" has been added re: #1331
  • If you already have a "guests" group, please delete it and re-create it under a different name.
• Notifications.push has a callback. It is now error-first.
  • If you have a plugin that listens for that callback, adjust accordingly. (I don't think there are any, but still...)
• The signatures for Topics.getTopicWithPosts, Topics.getTopicPosts and Posts.getPostsByTid have changed. See https://github.com/NodeBB/NodeBB/commit/7610c11cd1b9de53ce185227ab80f86d55d3bd69 for details.
• The hook filter:user.custom_fields has changed, it accepts an array of fields now.

This list will be updated as new breaking changes are added.

[Schamper]

No gotchas for 0.4.3?

[julian]

@Schamper As far as I know, there weren't any (unless we missed a couple...!). The upgrade path from 0.4.2 to 0.4.3 should be painless.

[Schamper]

I suppose this is still planned for 0.5.0? https://github.com/designcreateplay/NodeBB/issues/1437

[finid]

What, btw, happened to the Settings tab on users' profile page?

[Schamper]

@planner It's still there for me.

[finid]

@Schamper

I've cleared my cache and restarted the browser (Chromium), but it's not there.

[a_5mith]

@planner can also confirm it's there for me too.

[finid]

@a_5mith

Finally, I've got it back.

[a_5mith]

@planner

[HolyPhoenix]

Was gamification stuff going to show up soon? Or is that already capable through hooks and we are just waiting on a mod for that?

[psychobunny]

Or is that already capable through hooks and we are just waiting on a mod for that?

Pretty much, yeah. I have two in the works atm, ADR and Badges (badges being higher priority atm), not sure if anybody else has any they're working on

[baris]

Updated this forum to latest from master, let us know if you find any bugs!

[finid]

@baris

Can you spot the "bug" in this image, taken from the Unread page. Hint: Check the last update times.

[baris]

@planner don't see anything wrong with the update times, but there was a problem with the permissions which was letting you see topics from a hidden category, clicking on them would go to 404. Fixed that and updated.

What's wrong with the update times?

[finid]

@baris

Because I visit this forum at least 3 times/day and then seeing replied 8 days ago and replied 9 days ago on my Unread page tells me there's something wrong somewhere.

[baris]

Well if you go /unread again it should be fine, you shouldn't see those topics at all.

[baris]

Related issue: https://github.com/NodeBB/NodeBB/issues/1978

This is another breaking change. It effects anyone using the hook filter:user.custom_fields and filter:register.build to add custom data to users on registration.

If you were using filter:user.custom_fields to add new entries into the user object you can just switch the hook you are using to filter:user.create. No need to change anything else.

If you are using filter:register.build to add new entries into the registration form and want these entries to get added into the user object you need to use the hook filter:user.custom_fields. In your plugin that adds new entries into the registration form just add a listener for filter:user.custom_fields and add the fields that you added to the form into the array passed in, here is a sample.

// plugin.json
{
...
"hooks": [
    { "hook": "filter:user.custom_fields", "method": "addCustomFields"}
],
...
}

//plugin code
function addCustomFields(fields, callback) {
    fields.push('newCustomField1');  // must match the input name you added to regForm
    fields.push('otherCustomField1');
    callback(null, fields);
}

After this when a new user registers they will have newCustomField1 and otherCustomField1 entries in their user object.

@bentael nothing needs to be done for spam-be-gone since we don't want the captcha form entries in the database anyways.

Before this change it was possible to add any field into the registration form client side and it was inserted into the database. Now only the fields that core and plugins specify are inserted.