nodebb-plugin-reactions slow after selecting

[phenomlab]

@julian I can't tell because I don't think this specific extension is installed. For clarity, it's not the emoji picker from the composer, but this one

Actually, I think the plugin is nodebb-plugin-reactions

[phenomlab]

Anyone have any thoughts concerning this? Note, that the plugin is nodebb-plugin-reactions and not nodebb-plugin-emoji as first thought, so I have updated the title accordingly.

[julian]

@phenomlab it sounds like it might be some unoptimized code loading the entire emoji dialog pre-emptively on each post.

Is it every page thereafter that's slow, even non-topic pages?

[phenomlab]

@julian Yes, the entire site.

[phenomlab]

@julian @baris this might help shed some light

It seems that the emoji assets are being called multiple times after even just a simple select with nothing else. It remains that way until you reload the browser.

[phenomlab]

@julian @baris any thoughts?

Many thanks

[baris]

Not sure, does it happen on this site? You can test reactions in chat messages here, they use the same dialog. It's normal to see those images being loaded when you first open the dialog. Each emoji is a png image. They should be cached after first load though.

[phenomlab]

@baris Hmm - odd. Doesn't seem to happen here.

[julian]

@phenomlab Does it happen on your site with the chat reactions dialog?

[phenomlab]

@julian Yes, seems to be the case.

[phenomlab]

Any thoughts / updates? This might be something on my side with custom scripts etc, but would like to rule out any plugin related issues first.

[julian]

Let's say you open the reactions dialog, and in the dev tools you see a bunch of network requests to load the images (makes sense).

After you close the dialog, do you continue to see additional emoji-related network requests in the dev tools, when navigating through the site?

[phenomlab]

@julian yes. Seems they are being called even if not actually requested.