[nodebb-plugin-ns-embed] NS Embed

phenomlab

@baris @julian whilst I know this is a third party plugin, is there any way we can make it work with v3?

9819.582fabab51cbadc1b17e.min.js:9 Uncaught (in promise) TypeError: window.app.alertSuccess is not a function
    at g.<anonymous> (9819.582fabab51cbadc1b17e.min.js:9:39786)
    at g.onack (admin.min.js?v=ittabjn5q0s:152:50547)
    at g.onpacket (admin.min.js?v=ittabjn5q0s:152:49660)
    at Q.emit (admin.min.js?v=ittabjn5q0s:152:60280)
    at admin.min.js?v=ittabjn5q0s:152:43160

I don't think @Nicolas is here much these days, but I could be wrong..

julian

We could fork it out and fix. It's fairly simple, instead of assuming .alertSuccess is available, you now have to require the alerts module and call .success

phenomlab

@julian I think the fork makes more sense. I know several members are using this plugin and it overtook nodebb-plugin-embed I think..

julian

We usually propagate the change back, as I believe @Nicolas is accepting PRs.

phenomlab

@julian Would be useful if @Nicolas is accepting PR's

DownPW

I search dailymotion rules for this plugin.

I've tested this but doesn't work

Dailymotion
Watch

(?:<a.*?)?(?:https?:\\/\\/)?(?:www\\.)?dailymotion\\.com\\/video\\/([a-zA-Z0-9_-]{4,11})(?:.*?\\/a>)?

Replace

<div class='embed-wrapper'><div class='embed-container'><iframe  src='//www.dailymotion.com/embed/video/$1' frameborder='0' allowfullscreen></iframe></div></div>

julian

@DownPW shall I enhance link-previews plugin to do DailyMotion embed?

DownPW

Sure, if you want but I prefer a rule for nsembed because I use ogproxy

DownPW

@DownPW said in [nodebb-plugin-ns-embed] NS Embed:

I search dailymotion rules for this plugin.

I've tested this but doesn't work

Dailymotion
Watch

(?:<a.*?)?(?:https?:\\/\\/)?(?:www\\.)?dailymotion\\.com\\/video\\/([a-zA-Z0-9_-]{4,11})(?:.*?\\/a>)?

Replace

<div class='embed-wrapper'><div class='embed-container'><iframe  src='//www.dailymotion.com/embed/video/$1' frameborder='0' allowfullscreen></iframe></div></div>

Anyone ?

KnickKnack

Is this plugin compatible with 3.x? Any active development as far as you can tell?