Community

Jus filled and issue for some odd behaviour i just saw on this community:

User slug not generating link to user profile on a post reply. · Issue #5363 · NodeBB/NodeBB

Just saw the issue on the community.nodebb.org site: Can be reproduced/seen on this post: https://community.nodebb.org/topic/10098/loading-nodebb-in-my-site-through-iframe I think the problem should be the space or ' character present in...

favicon

GitHub (github.com)

Can be seen on this thread: https://community.nodebb.org/topic/10098/loading-nodebb-in-my-site-through-iframe

As you can see, in the replay the @userslug is not highlighted and do not generate a link to the OP profile. The reply was posted using the "reply" button of the OP post.

Thanks!

Looks like a standalone app as opposed to a web library, unless I misread.

In any case, we don't typically offer compatibility with X markdown editor or whatnot for a variety of reasons:

Markdown can be disabled in favour of other parsing languages (like BBCode, etc) There needs to be support for post-related functions offered by the existing composer, such as topic images, file uploads, tags support, etc.

The short of it is, it takes quite a bit of work to ensure compatibility and full functionality, which is why at current we only support default and redactor.

@baris thank you very much! I will try to find out what is not working here! I'll let you know if there's a possible bug involved.

@julian thanks a lot! And for the second question, is there any way to do it?

Thanks again.

EDIT (just to clarify, in order to be helpfull for anyone in the future): Since my image, didn't had the data-state="unloaded" (in fact id didn't have the data-state at all on the img tag) i had to first, use
posts.unloadImages(post); an then posts.loadImages(); to get the image loaded. That's because posts.loadImages() only searches for data-state="unloaded", posts.unloadImages. gets all images in the post provided without the class .not-reponsive and puts the data-state="unloaded" in each img tag.

@baris Thank you!.

Happy to help! 🙂

@jarey it helped me:

Notification: user_mentioned_you_in · Issue #4915 · NodeBB/NodeBB

Hello! At mention the user, he receives a notification containing: user_mentioned_you_in NodeBB 1.1.0

favicon

GitHub (github.com)

@trevor i personally think this is a great approach.

@marcelo-lopes escape the comma as an HTML entity:

text.replace(/,/g, ',')

@jarey I believe the approach is to add breaking changes to major releases so, probably for 2.0.0 I think

Anyone knows if theres the possibility of registering an user link in the dropdown, that will be public only? Like the case for example of the "chat link", but registered vía filter:user.profileLinks hook.

Since in that hook theres no user info, i cannot check if the user visualizing the page is the users itself that is visualizing his/her profile or if the user its logged in, to restrict the link registration.

I want to implement the functionality of "ignore users" showing a link that can be used to ignore, unignore from the user profile. But it has no sense to show the link "ignore/unignore user" if it is the user itself or the user visiting the profile is not logged in.

I know it can be easilly achived by adding one more attribute to the link object and modifying the menu.tpl with minor changes to reflect this behaviour (checking the new field), and without altering the existing behaviour of the theme. If the answer to the previous question is "no", what is needed to get a pull request including this behaviour accepted? Modification in all stable themes? (persona,lavender,vanilla?).
Or would it be more suitable a request of a new action hook for action:user:viewProfile for example? To be able to make business logic checks with the data, and altering the content sent to the page for example?

PS: Is there any way of contributing to document the list of hooks with a short explanation of each one? For example when they're fired and wich information do they send? I think it would be a good improvement for the documentation in order to make it easy to the plugin dev to without the need to dive into the core and check each hook one by one looking for one satisfying their needs. I wouldn't mind to throw 2/3 lines explaining the hooks I found useful that i'm seeing on my little plugin experiments from a noob perspective. Ping @administrators

Thanks again and sorry for modifying the thread question.

Thanks for your reply @julian

@yariplus said in :

Yep, you can use this function here the same way.

https://github.com/jarey/nodebb-plugin-tagstitle/blob/master/library.js#L17

Just declare it at the global scope so that your hook can see it.

Thank you very much @yariplus ; I achieved what i needed thanks to your help.

I was able to see my custom page with my custom messages like you pointed out.

Then, because i only wanted to change the message displayed on the 403 error regarding the logic on my plugin i was able to change it to using another method; only if it could help anyone else, i just imported the helpers module and called the function notAllowed with my custom message:

var helpers = require.main.require('./src/controllers/helpers'); // filter:topic.build tagsTitle.topicBuild = function (data, callback) { if (data.templateData.privileges.errorMessage) { helpers.notAllowed(data.req,data.res, data.templateData.privileges.errorMessage); }else{ callback(null, data); } };

Thanks again. I learned a lot of basic stuff just trying your suggestions.

Kind regards.

@baris woops excuse me for opening a new thread, just saw it browsing that thread and wanted to report it. Feel free to delete this topis if you think is useless.

Regards.

@Kowlin said:

Yup, this behavior is odd in my opinion, and I think that NodeBB should hide the thread from the list once its deleted, (not purged) but still show it for the thread creator and any staff with the privileges.

In this scenario i wasn't admin neither i have more privileges than standar user, but i still think i shoul be able to navigate to the thread following the link to the removed message.

It was a cache issue. Clearing the cache solved the problem. Sorry for yhe false positive.

Thanks for your replies and attentio .

Regards.

Oh didnt see that issue. Thanks for your reply. Just wondering what would you bring to the theme. I'm sure it will be nice.

@julian said:

@baris Haha, you beat me to it.

v0.11.6 has this change now.

Glad to be helpfull, even tho only reporting haha.

Nice work 👍

@BDHarrington7
Use

307 Temporary Redirect

favicon

(manpages.debian.org)

! 😉

kill -s USR1 $(fgrep -f "app.js")

or even shorter with pkill

pkill -USR1 -f "app.js"

Substitute -USR1 with -SIGHUP and you got yourself a quick and easy build-tool command to restart NodeBB, when changing files. 🙂
(I'm using SublimeText / Atom)

@psychobunny if i get something working, would submit that PR.

Thanks.