Composer lagging

teh_g

Any errors in the browser console? Can you reproduce it here, as this is latest as well

Nope, this is working wonderfully here.

Chrome 52 x64
Windows 10 AU x64

Made a test user for you if you can try and repro:
www.gamingexodus.com
User: test_user
Password: 3*#c4&Hj$%Pa*mP3qF

Error in my browser console:

Navigated to https://gamingexodus.com/
Uncaught ReferenceError: screenfull is not defined
composer.js?v=ec924c51-a24c-4316-9fdc-1d0be39ae9a2:23 Uncaught ReferenceError: screenfull is not defined
composer.enhance @ composer.js?v=ec924c51-a24c-4316-9fdc-1d0be39ae9a2:23
(anonymous function) @ composer.js?v=ec924c51-a24c-4316-9fdc-1d0be39ae9a2:26
(anonymous function) @ nodebb.min.js?ec924c51-a24c-4316-9fdc-1d0be39ae9a2:24
(anonymous function) @ nodebb.min.js?ec924c51-a24c-4316-9fdc-1d0be39ae9a2:24
(anonymous function) @ nodebb.min.js?ec924c51-a24c-4316-9fdc-1d0be39ae9a2:24
(anonymous function) @ nodebb.min.js?ec924c51-a24c-4316-9fdc-1d0be39ae9a2:24
l @ nodebb.min.js?ec924c51-a24c-4316-9fdc-1d0be39ae9a2:1
fireWith @ nodebb.min.js?ec924c51-a24c-4316-9fdc-1d0be39ae9a2:1
T @ nodebb.min.js?ec924c51-a24c-4316-9fdc-1d0be39ae9a2:3
i @ nodebb.min.js?ec924c51-a24c-4316-9fdc-1d0be39ae9a2:3

The NodeBB log shows:

[minifier] file not found, node_modules/nodebb-plugin-composer-default/node_modules/screenfull/dist/screenfull.js

teh_g

[minifier] file not found, node_modules/nodebb-plugin-composer-default/node_modules/screenfull/dist/screenfull.js

For that error, the file definitely does not exist. It looks like it might be looking in the wrong folder?

psychobunny

This might be a silly question, but you did run npm i after upgrading to pull the latest composer right?

teh_g

@psychobunny Hmm, I didn't. I thought the nodebb --upgrade pulled all the latest. I don't see any available upgrades for plugins. Let me give that a go though.

Also, that should be added to the upgrade doc if it is required

psychobunny

./nodebb upgrade does both node app --upgrade and npm i - I'm pretty sure that's in the docs. Hope that worked for you.

pichalite

works fine on my installation after upgrade. screenfull was installed as part of composer plugin update when I ran ./nodebb upgrade

teh_g

@psychobunny said in Composer lagging:

This might be a silly question, but you did run npm i after upgrading to pull the latest composer right?

I ran npm i, no warnings or errors were returned, then did a restart of NodeBB via the admin console. Issue persists. Same error in the Chrome console as well.

Upgrade steps I took (edited to show I did the right commands):

sudo service nodebb stop
cd /path/to/forums
git fetch
git reset --hard origin/v1.x.x
./nodebb upgrade
sudo service nodebb start

psychobunny

./nodebb upgrade , not ./nodebb --upgrade

pichalite

@teh_g ./nodebb --upgrade?

teh_g

@pichalite said in Composer lagging:

@teh_g ./nodebb --upgrade?

@psychobunny said in Composer lagging:

./nodebb upgrade , not ./nodebb --upgrade

The docs say ./nodebb upgrade. I did get output from the command without the '--'. I will run it with it again though.

teh_g

@teh_g said in Composer lagging:

@pichalite said in Composer lagging:

@teh_g ./nodebb --upgrade?

@psychobunny said in Composer lagging:

./nodebb upgrade , not ./nodebb --upgrade

The docs say ./nodebb upgrade. I did get output from the command without the '--'. I will run it with it again though.

~~It actually errors if you do --upgrade!~~

Ignore this, I did the right thing in the first place.

pichalite

@teh_g yes, coz it's not valid

teh_g

@pichalite said in Composer lagging:

@teh_g yes, coz it's not valid

I promise I know how to read. I did nodebb upgrade. I just misread your post. It has been a long day of meetings and not enough coffee.

As far as I can tell, everything is upgraded happily. I do see the ./node_modules/screenfull/dist/screenfull.js file. The only interesting thing is the error in the logs is looking under node_modules/nodebb-plugin-composer-default/node_modules/screenfull/dist/screenfull.js

pichalite

@teh_g what's your npm version?

teh_g

@pichalite said in Composer lagging:

@teh_g what's your npm version?

$ npm -v
3.10.3
$ node --version
v6.3.1

pichalite

@teh_g that's the problem right there... npm v3 installs dependencies in the root node_modules directory. Composer is looking for the file in it's own node_modules directory.

teh_g

@pichalite said in Composer lagging:

@teh_g that's the problem right there... npm v3 installs dependencies in the root node_modules directory. Composer is looking for the file in it's own node_modules directory.

Should I roll back to Node.js 4.x?

pichalite

@teh_g blame @pitaj for making you upgrade node.js coz he wrote his calendar plugin with ES6 features even though NodeBB itself doesn't support ES6 yet.

Should I roll back to Node.js 4.x?

I guess so unless there is an alternative.

teh_g

@pichalite said in Composer lagging:

@teh_g blame @pitaj for making you upgrade node.js coz he wrote his calendar plugin with ES6 features even though NodeBB itself doesn't support ES6 yet.

Should I roll back to Node.js 4.x?

I guess so unless there is an alternative.

I used n to set the LTS release as my node version.

$ npm -v
2.15.8
$ node -v
v4.4.7

I am still seeing the same error. I did an npm rb, but the issue continues. I am still not seeing the screenfull dependency in the Composer folder.

teh_g

OK. So I ended up going the wrecking ball route. I moved the existing ./node_modules folder to a backup location, then ran the npm install --production command. This rebuilt the node_modules folder for me with the proper dependencies.

I do think a warning should be added to the documentation for which versions of node and npm are supported.