Composer lagging
-
This might be a silly question, but you did run
npm iafter upgrading to pull the latest composer right? -
@psychobunny Hmm, I didn't. I thought the nodebb --upgrade pulled all the latest. I don't see any available upgrades for plugins. Let me give that a go though.
Also, that should be added to the upgrade doc if it is required
-
./nodebb upgradedoes bothnode app --upgradeandnpm i- I'm pretty sure that's in the docs. Hope that worked for you. -
works fine on my installation after upgrade.
screenfullwas installed as part of composer plugin update when I ran./nodebb upgrade -
@psychobunny said in Composer lagging:
This might be a silly question, but you did run
npm iafter upgrading to pull the latest composer right?I ran
npm i, no warnings or errors were returned, then did a restart of NodeBB via the admin console. Issue persists. Same error in the Chrome console as well.Upgrade steps I took (edited to show I did the right commands):
sudo service nodebb stop cd /path/to/forums git fetch git reset --hard origin/v1.x.x ./nodebb upgrade sudo service nodebb start -
./nodebb upgrade, not./nodebb --upgrade
-
@pichalite said in Composer lagging:
@teh_g
./nodebb --upgrade?@psychobunny said in Composer lagging:
./nodebb upgrade, not./nodebb --upgradeThe docs say ./nodebb upgrade. I did get output from the command without the '--'. I will run it with it again though.
-
@teh_g said in Composer lagging:
@pichalite said in Composer lagging:
@teh_g
./nodebb --upgrade?@psychobunny said in Composer lagging:
./nodebb upgrade, not./nodebb --upgradeThe docs say ./nodebb upgrade. I did get output from the command without the '--'. I will run it with it again though.
It actually errors if you do --upgrade!Ignore this, I did the right thing in the first place.
-
@pichalite said in Composer lagging:
@teh_g yes, coz it's not valid
I promise I know how to read. I did
nodebb upgrade. I just misread your post. It has been a long day of meetings and not enough coffee.As far as I can tell, everything is upgraded happily. I do see the
./node_modules/screenfull/dist/screenfull.jsfile. The only interesting thing is the error in the logs is looking undernode_modules/nodebb-plugin-composer-default/node_modules/screenfull/dist/screenfull.js -
@pichalite said in Composer lagging:
@teh_g what's your npm version?
$ npm -v 3.10.3 $ node --version v6.3.1 -
@pichalite said in Composer lagging:
@teh_g that's the problem right there... npm v3 installs dependencies in the root node_modules directory. Composer is looking for the file in it's own node_modules directory.
Should I roll back to Node.js 4.x?
-
-
@pichalite said in Composer lagging:
@teh_g blame @pitaj for making you upgrade node.js coz he wrote his calendar plugin with ES6 features even though NodeBB itself doesn't support ES6 yet.
Should I roll back to Node.js 4.x?
I guess so unless there is an alternative.
I used n to set the LTS release as my node version.
$ npm -v 2.15.8 $ node -v v4.4.7I am still seeing the same error. I did an
npm rb, but the issue continues. I am still not seeing the screenfull dependency in the Composer folder. -
OK. So I ended up going the wrecking ball route. I moved the existing ./node_modules folder to a backup location, then ran the
npm install --productioncommand. This rebuilt the node_modules folder for me with the proper dependencies.I do think a warning should be added to the documentation for which versions of node and npm are supported.
-
Same error.
