[nodebb-plugin-emoji-extended] Emoji Extended

Xiph

Activating the plugin crashes NodeBB with the following error:
error: Object #<Object> has no method 'persistOnEmpty' TypeError: Object #<Object> has no method 'persistOnEmpty' at resetConfigIfEmpty (C:\nodebb\node_modules\nodebb-plugin-emoji-extended\index.js:1:850) at Object.module.exports.configDefaults (C:\nodebb\node_modules\nodebb-plugin-emoji-extended\index.js:1: 1072) at C:\nodebb\src\plugins.js:347:23 at C:\nodebb\node_modules\async\lib\async.js:111:13 at Array.forEach (native) at _each (C:\nodebb\node_modules\async\lib\async.js:32:24) at Object.async.each (C:\nodebb\node_modules\async\lib\async.js:110:9) at Object.Plugins.fireHook (C:\nodebb\src\plugins.js:345:12) at C:\nodebb\src\plugins.js:400:15 at C:\nodebb\src\plugins.js:100:5 info: [app] Shutdown (SIGTERM/SIGINT) Initialised. info: [app] Database connection closed. info: [app] Shutdown complete.

EDIT: I'd add newlines to the above code block, but that just breaks it =P

frissdiegurke

@Xiph should be fixed now, please update to 0.2.4-2 (will reset settings), thanks for reporting

frissdiegurke

I've just added a small client-side API to provide functions like adding the textcomplete to other fields.
please update to 0.2.5-3 in order to allow other plugins/scripts to use this.

a_5mith

Bug time, haven't updated yet though. Go into your settings, turn on open external urls in a new window, try and click an emote in the drop down. Still parses, but opens a blank tab, even though it's an internal URL.

frissdiegurke

@a_5mith you mean the "Use Outgoing Links Warning Page"? I don't find any option like you mentioned, but the warning page causes problems...

@baris @psychobunny @julian would someone of you like to tell me what this option does or where the relevant part can be found within the src? would save much work thought.
I guess this may be best fixed within core by not handling plain a-tags without href attribute as external links.
If I'm right this causes the problem(s)

<baris>

That setting is supposed to show a warning page when you click a link that goes outside of nodebb. The relevant code is in ajaxify.js i think around here

NodeBB/public/src/ajaxify.js at master · NodeBB/NodeBB

Node.js based forum software built for the modern web - NodeBB/public/src/ajaxify.js at master · NodeBB/NodeBB

GitHub (github.com)

frissdiegurke

@baris should be solved with gh#1775 then

a_5mith

Hey! I mean in user settings, not the ACP, there's an option in there to open external links in a new tab. But seems similar to the bug you've just found, will update and see if it fixes.

frissdiegurke

@a_5mith yup, works all fine now even if both options are enabled, thanks for report

frissdiegurke

since there have been major changes I bump this topic now:

The new version 0.3.0-1 includes my emoji-parser dependency which manages the emoji images to stay up-to-date besides other minor improvements (like the long-awaited : within alt-tags...)

Thanks to @julian it should be compatible with the new NodeBB version 0.5.0 as soon as it arrives

Since the movement from emoji-images to my self-written emoji-parser is a major change, please notice me about bugs that may ocur

esiao

@frissdiegurke
Not related to this new version since I have the problem since the 2.x.x one but the Emoticons are not displaying (broken image) and in my console there's this error

GET http://localhost/plugins/nodebb-plugin-emoji-extended/images/frowning.png net::ERR_CONNECTION_REFUSED

I don't know if it's a misconfiguration of wamp by my side or an issue with the plugin.

frissdiegurke

@esiao said:

@frissdiegurke
Not related to this new version since I have the problem since the 2.x.x one but the Emoticons are not displaying (broken image) and in my console there's this error
GET http://localhost/plugins/nodebb-plugin-emoji-extended/images/frowning.png net::ERR_CONNECTION_REFUSED 
I don't know if it's a misconfiguration of wamp by my side or an issue with the plugin.

what does base_url within your config.json contain? I guess it's like "base_url": "http://localhost". If so please put your public domain-name there

esiao

@frissdiegurke
Yes it's localhost but since I'm using it on localhost that's normal. I may need to create a vhost and change the config after.

frissdiegurke

@esiao said:

@frissdiegurke
Yes it's localhost but since I'm using it on localhost that's normal. I may need to create a vhost and change the config after.

localhost should work if you browse the board from the same machine (or virtual machine). In this case the emoji should get displayed correctly

esiao

@frissdiegurke
I agree but that's not what is happening.
The url taken is http://localhost/plugins/nodebb-plugin-emoji-extended/images/grinning.png
And if I try to open it it's a 404.
I think that's because of wamp. It may expect an adress like http://localhost/Github/NodeBB/node_modules/nodebb-plugin-emoji-extended/emoji/grinning.png because there's no plugins folder in my www.
So creating a vhost may fix this. I'll try and keep you updated.

esiao

@frissdiegurke
And this is not working
GET http://gg.dev/plugins/nodebb-plugin-emoji-extended/images/frowning.png 404 (Not Found)
gg.dev is my vhost.

frissdiegurke

0.3.1-1

Some better mappings like :D to instead of (which gets mapped by xD now) implemented.
Also copying a emoji now copies the original text (shortens instead of :...: when used).
The title-attribute also contains the shortens (or the name of the emoji without : if no shorten got used).
Fixed code-exclusion for code-tags containing attributes.
Minor fixes.

0.3.1-2

Added button to open dialog with emoji-overview to composer

@julian / @psychobunny I suggest an update for this board

esiao

@frissdiegurke Yeah that's good news

? Offline

@frissdiegurke, excellent updates I can't wait to put them into effect!
Now, if only there was a way to cap the number of emojis users put in their posts

<baris>

Updated to 0.3.1-2, that modal with so many emojis (drunk)