[nodebb-plugin-imgur] Imgur Plugin

[baris]

Just pick an application name and use Anonymous usage without user authorization rest is optional.

[Giorgio Chiodi]

@baris imgur insists on this

Authorization callback URL

What should I do?

[baris]

Just put in your site url.

[julian]

Further documentation: https://docs.nodebb.org/en/latest/admin/uploads.html?highlight=imgur

[yuanja]

Hi @Baris, is there a way to configure the plugin to upload the images to a specific account? I believe the current plugin uploads everything to the "anonymous" area.

[DanaGriffin]

@baris is there a reason why it wont allow pdf uploads? I keep getting an error that uploads are not enabled.

[a_5mith]

@DanaGriffin Imgur will only allow images, if you want to upload other files, you will need to use the local file uploader.

[DanaGriffin]

@a_5mith is there a reason why I can do it on the website then? here is a scanned pdf on imager.

edit: looks like it converts it to a png...huh

[a_5mith]

@DanaGriffin said:

@a_5mith is there a reason why I can do it on the website then? here is a scanned pdf on imager.

edit: looks like it converts it to a png...huh

Can you upload other files no problem? Not sure if the imgur plugin works with PDF in that case then. Not sure if it uses "allowed" file types.

[DanaGriffin]

@a_5mith Yeah all other files upload without a hitch.

[Silvina]

Some observations,

In community nodebb forums, the image uploads i made have the https url (https://i.imgur.com/WUSfO3l.jpg) , however in my own hosted forums, the images i upload have the http url,

eg: http://i.imgur.com/yieHx4c.png

how do i configure it to auto use the https url?

[baris]

What version of the plugin do you have? The latest versions always return https.

[Chris]

Was getting this error:

19/11 13:33 [6867] - error: [plugins] Problem executing hook: filter:uploadImage err: Error
 at Request._callback (/srv/forums/node_modules/nodebb-plugin-imgur/index.js:104:15)
 at Request.self.callback (/srv/forums/node_modules/request/request.js:372:22)
 at Request.emit (events.js:98:17)
 at Request.<anonymous> (/srv/forums/node_modules/request/request.js:1317:14)
 at Request.emit (events.js:117:20)
 at IncomingMessage.<anonymous> (/srv/forums/node_modules/request/request.js:1265:12)
 at IncomingMessage.emit (events.js:117:20)
 at _stream_readable.js:943:16
 at process._tickDomainCallback (node.js:463:13) 

Using latest (as of yesterday night) nodebb 0.6.x and version of latest plugin.

[baris]

Couldn't repro this, but I went ahead and updated the dependencies on the imgur plugin. The new version is 0.1.2. I can upload images fine with that version and nodebb commit https://github.com/NodeBB/NodeBB/commit/8d8731c609cc470d4cba6d477d914fc17b850c37

[Chris]

@baris to be fair it seems to work just uploading images but when I was using a plugin from @Schamper which set avatars it always seemed to error out. (Only the imgur plugin though, not his).

I'll give it a go with the updated dependencies.

[Schamper]

@baris @Chris to add to that, it's regarding setting a user avatar using a url.

[baris]

Took a look into this, it is caused by this change https://github.com/NodeBB/NodeBB/commit/969c3a77cf3eb3327402df731c9152ac8cd626e2.

The plugins for filter:uploadImage doesn't send the passed in data as is but only returns an object that is {url: 'uploaded url', name: 'file name if any'} This is quite different than other plugins that pass back whatever is sent in. Obviously that doesn't work for upload plugins. For example you pass in a file object that points to a tmp file on disk and get back an url.

I'll revert that change for now and use the correct data.url property.

[Schamper]

@baris I'm not even calling the hook directly, but piggybacking it from the user.uploadProfileImageFromUrl socket endpoint.

[baris]

Well SocketUser.uploadProfileImageFromUrl was crashing, it shouldn't crash now.

[kevin]

Is there any way to change this so this so the end result is simply a URL without all the markdown? When combined with the other image embed plugin there isnt a need for it, so it would be a bit cleaner looking to the end user. Thanks.