Your browser does not seem to support JavaScript. As a result, your viewing experience will be diminished, and you have been placed in read-only mode.

Please download a browser that supports JavaScript, or enable it if it's disabled (i.e. NoScript).

0.8.0 Breaking Changes

NodeBB Development

1835

<baris> NodeBB last edited by baris
Hook changes

Filter
- filter:user.custom_fields removed see this commit
- filter:user.delete deprecated, use static:user.delete instead, now
  - It is passed { uid: uid } instead of just uid, and is fired before user data is actually deleted, so you have one last chance to look up stuff if needed.
Other changes
- Theme developers should now explicitly set the baseTheme in their theme.json if their theme is not based on Persona. Set this value to nodebb-theme-vanilla
- TBD
1 Reply Last reply
Reply Quote 1

Suggested Topics

Gotchas for 0.6.0
NodeBB Development • 0.6.0 nodebb • • Julian Lam

1

0
Votes

1
Posts

1219
Views

I know I made a promise to have the 0.5.x branch last more than 2 releases, but we added more breaking changes again, and 0.5.0 hasn't even been released yet 😆

In any case, for those plugin developers who are interested:
Notification pushed action hook (action:notification.pushed) incoming data has changed: From: An object containing the notification data To: This object -- {notification: notification, uids: uids});
As always, this list will be updated as new breaking changes are added. In the case of this list -- don't commit and publish your change to npm yet, as 0.6.0 has not launched. We recommend you maintain these changes in a separate branch until then.
Topic watching change
NodeBB Development • breaking 1.1.0 • • <baris>

1

2
Votes

1
Posts

1212
Views

Please see https://github.com/NodeBB/NodeBB/pull/4662

If you have a custom theme that has a partials/topic/watch.tpl you will need to update it for 1.1.0.

You can see the changes you need to make in https://github.com/NodeBB/nodebb-theme-persona/pull/278/files

Persona, vanilla and lavender themes are already updated.
barisusakli created this issue in NodeBB/NodeBB closed topic watching #4662 barisusakli created this issue in NodeBB/nodebb-theme-persona closed Topic watching #278
T

config.json's url ignored on Google Cloud Platform
Technical Support • 0.8.0 solved • • Tadej

3

0
Votes

3
Posts

1572
Views

T

Aargh - i just forgot to mark " Allow HTTP traffic " at console. Works just fine 😆
1.0.0 Breaking Changes
NodeBB Development • 1.0.0 breaking • • <baris>

10

3
Votes

10
Posts

6909
Views

S

0_1457071644710_nbb1.0.0.PNG

No announcement thread in the announcements section?

Congratulations, guys! NodeBB has come a long way.
1.10.0 Breaking Changes
NodeBB Development • breaking 1.10.0 • • <baris>

3

1
Votes

3
Posts

2070
Views

Hi,
I think I have discovered another breaking change that you didn't mention, though it is probably super-niche.

This commit: https://github.com/NodeBB/NodeBB/commit/ec91ef1c644044bba44198b031913655e784b4bb
broke our custom SSO plugin. The result was that after successfully logging in our external identity provider and being redirected to our Forum's callback endpoint, I was ending up not logged in (the button in the header still said "Log in") and stuck on /register/complete roadblock. It looked like our Passport strategy verify callback, that parses output from the identity provider and fetches user data via OAuth2 was not invoked at all.

It turns out that the changes in this commit don't play well together with passport-oauth2 (https://github.com/jaredhanson/passport-oauth2) internal ability to protect against CSRF (which we were using). This strategy was already using state parameter to pass its own CSRF token. I don't have more time to investigate but I suspect things shipwrecked when NodeBB overwrote the state parameter with its own CSRF token.

Turning off passport-oauth2 internal CSRF protection (by removing state: true from its options) fixed the issue.
0 julianlam committed to NodeBB/NodeBB closes #6553

| |

1 / 1

0.8.0 Breaking Changes

Hook changes

Filter

Other changes

Suggested Topics

Gotchas for 0.6.0 NodeBB Development • 0.6.0 nodebb • • Julian Lam

Topic watching change NodeBB Development • breaking 1.1.0 • • <baris>

config.json's url ignored on Google Cloud Platform Technical Support • 0.8.0 solved • • Tadej

1.0.0 Breaking Changes NodeBB Development • 1.0.0 breaking • • <baris>

1.10.0 Breaking Changes NodeBB Development • breaking 1.10.0 • • <baris>

Gotchas for 0.6.0
NodeBB Development • 0.6.0 nodebb • • Julian Lam

Topic watching change
NodeBB Development • breaking 1.1.0 • • <baris>

config.json's url ignored on Google Cloud Platform
Technical Support • 0.8.0 solved • • Tadej

1.0.0 Breaking Changes
NodeBB Development • 1.0.0 breaking • • <baris>

1.10.0 Breaking Changes
NodeBB Development • breaking 1.10.0 • • <baris>