[nodebb-plugin-ns-twitch-monitor] NS Twitch Monitor

rod

@Nicolas said in [nodebb-plugin-ns-twitch-monitor] NS Twitch Monitor:

First 3, timeout was reached to get data from Twitch.
Last one, Twitch was not available.

Would those types of errors caused previous versions of your plugin to cause NodeBB to restart?

I am very happy that although the plugin could not communicate with Twitch it did not cause the double restart of NodeBB that previous versions were triggering.

Thank you.

Nicolas

Before, I had 100% trust in Twitch API. 3.0.5 introduced several checks, if something goes wrong with Twitch. So answer is yes, such errors could produce exceptions.

Nicolas

Version 3.1.0

New version is available. Summary: improved UX for a Client ID. Also validation method is changed.

Add validation for a Client ID as a separate action
Add ability to save any Client ID
Change Client ID validation method

teh_g

@Nicolas, thanks for the work on this! My members love it!

I ran into an error today that crashed my NodeBB instance. The error appears to come from Twitch Monitor:

13/12 09:57 [30258] - error: [plugins/twitch-monitor] Error has occurred, can not get streams resource, code: 500
node_redis: Deprecated: The ZRANK command contains a "null" argument.
This is converted to a "null" string now and will return an error from v.3.0 on.
Please handle this in your code to make sure everything works as you intended it to.
Unhandled rejection ReplyError: EXECABORT Transaction discarded because of previous errors.
    at parseError (/var/www/nodebb/forums/node_modules/redis-parser/lib/parser.js:167:12)
    at parseType (/var/www/nodebb/forums/node_modules/redis-parser/lib/parser.js:228:14)

Nicolas

@teh_g no, error is not from a Twitch Monitor.

After this error notification:

13/12 09:57 [30258] - error: [plugins/twitch-monitor] Error has occurred, can not get streams resource, code: 500

Twitch monitor schedules next update. There is no work with a database.

teh_g

@Nicolas I've been running into a ton of errors from the Twitch plugin lately. It actually caused the NodeBB process to full on die eventually. Here is the error that has been happening:

26/4 13:27:19 [20245] - [31merror[39m:  TypeError: Cannot read property 'forEach' of null
    at /var/www/nodebb/forums/node_modules/nodebb-plugin-ns-twitch-monitor/plugin/twitch/api.js:78:36
    at transform (/var/www/nodebb/forums/node_modules/nodebb-plugin-ns-twitch-monitor/plugin/twitch/api.js:105:27)
    at /var/www/nodebb/forums/node_modules/nodebb-plugin-ns-twitch-monitor/plugin/twitch/api.js:76:35
    at fn (/var/www/nodebb/forums/node_modules/nodebb-plugin-ns-twitch-monitor/node_modules/async/lib/async.js:746:34)
    at /var/www/nodebb/forums/node_modules/nodebb-plugin-ns-twitch-monitor/node_modules/async/lib/async.js:1213:16
    at /var/www/nodebb/forums/node_modules/nodebb-plugin-ns-twitch-monitor/node_modules/async/lib/async.js:166:37
    at /var/www/nodebb/forums/node_modules/nodebb-plugin-ns-twitch-monitor/node_modules/async/lib/async.js:706:43
    at /var/www/nodebb/forums/node_modules/nodebb-plugin-ns-twitch-monitor/node_modules/async/lib/async.js:167:37
    at /var/www/nodebb/forums/node_modules/nodebb-plugin-ns-twitch-monitor/node_modules/async/lib/async.js:1209:30
    at /var/www/nodebb/forums/node_modules/nodebb-plugin-ns-twitch-monitor/plugin/twitch/api.js:52:13
    at /var/www/nodebb/forums/node_modules/nodebb-plugin-ns-twitch-monitor/node_modules/async/lib/async.js:52:16
    at /var/www/nodebb/forums/node_modules/nodebb-plugin-ns-twitch-monitor/node_modules/async/lib/async.js:1209:30
    at Request._callback (/var/www/nodebb/forums/node_modules/nodebb-plugin-ns-twitch-monitor/plugin/twitch/api.js:45:21)
    at Request.self.callback (/var/www/nodebb/forums/node_modules/request/request.js:188:22)
    at emitTwo (events.js:106:13)
    at Request.emit (events.js:191:7)
26/4 13:27:19 [20245] - [32minfo[39m: [app] Shutdown (SIGTERM/SIGINT) Initialised.
26/4 13:27:19 [20245] - [32minfo[39m: [app] Database connection closed.
26/4 13:27:19 [20245] - [32minfo[39m: [app] Web server closed to connections.
26/4 13:27:19 [20245] - [32minfo[39m: [app] Shutdown complete.
[cluster] Child Process (20245) has exited (code: 1, signal: null)

Nicolas

Version 3.1.1

A new version is available. It addresses occasional unavailability of streams in the Twitch API.

@teh_g try to upgrade the plugin.

teh_g

@Nicolas said in [nodebb-plugin-ns-twitch-monitor] NS Twitch Monitor:

Version 3.1.1

A new version is available. It addresses occasional unavailability of streams in the Twitch API.

@teh_g try to upgrade the plugin.

I'll update and monitor.

teh_g

Things have been looking good @Nicolas

As a note, I upgrade to 1.5 and am seeing the following warning, 8/5 14:14:06 [18121] - warn: [widgets.render] passing a string is deprecated!, filter:widget.render:ns_twitch_monitor. Please set hookData.html in your plugin.

julian

@teh_g Well that was quick

teh_g

@julian said in [nodebb-plugin-ns-twitch-monitor] NS Twitch Monitor:

@teh_g Well that was quick

What can I say, I'm an early adopter with not too many plugins

Community