baseTheme causing issues?

[drew]

I'm attempting to extend lavender theme to just customise a few places so I'm taking the baseTheme approach that was introduced by @psychobunny .

When I try and use my theme which just has 1 template file everything breaks:

Internal error.
Oops! Looks like something went wrong!
/
Failed to lookup view "footer" in views directory "/var/rolemother/public/templates"

I followed the guide here: https://docs.nodebb.org/en/latest/themes/create.html but I clearly got somethinig wrong?

Anyone able to take a look please?

Repo:
https://bitbucket.org/drewdotpro/nodebb-theme-rolemother/overview

In a package.json put:
"nodebb-theme-rolemother": "git+https://bitbucket.org/drewdotpro/nodebb-theme-rolemother.git",

[drew]

Seen in logs:
It looks like it's trying to load in partials and other template files from the new theme and not the baseTheme maybe? BTW NodeBB 0.7

21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/category_list.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/breadcrumbs.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/category_tools.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/category_sort.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/share_dropdown.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/category_tags.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/paginator.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/move_thread_modal.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/noscript/paginator.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/menu.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/noscript/warning.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/breadcrumbs.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/topic/badge.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/topic/post-menu.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/post_bar.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/post_bar.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/paginator.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/move_thread_modal.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/fork_thread_modal.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/move_post_modal.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/noscript/paginator.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/category_tags.tpl
21/6 15:38 [1328] - warn: [meta/templates] Partial not loaded: partials/breadcrumbs.tpl
21/6 15:39 [1328] - info: NodeBB Ready
21/6 15:39 [1328] - info: Enabling 'trust proxy'
21/6 15:39 [1328] - info: NodeBB is now listening on: 0.0.0.0:4567
21/6 15:39 [1328] - error: /login
Error: Failed to lookup view "footer" in views directory "/var/rolemother/public/templates"
at EventEmitter.render (/var/rolemother/node_modules/express/lib/application.js:579:17)
at Object.async.parallel.footer (/var/rolemother/src/middleware/middleware.js:177:9)
at /var/rolemother/node_modules/async/lib/async.js:580:25
at /var/rolemother/node_modules/async/lib/async.js:122:13
at _each (/var/rolemother/node_modules/async/lib/async.js:46:13)
at Object.async.each (/var/rolemother/node_modules/async/lib/async.js:121:9)
at _parallel (/var/rolemother/node_modules/async/lib/async.js:579:20)
at Object.async.parallel (/var/rolemother/node_modules/async/lib/async.js:595:9)
at /var/rolemother/src/middleware/middleware.js:172:9
at Object.csrf [as applyCSRF] (/var/rolemother/node_modules/csurf/index.js5)

[yariplus]

This might still be relevant.
https://community.nodebb.org/topic/2830/developing-a-child-theme-vs-forking-an-existing-theme

[drew]

Yeah, I think you're right. I'll have to for it just to change a template file then keep my github version up to date with lavender fixed through merges. Thanks for your feedback.

[drew]

@julian the inherited themes didn't work before, but is it possible that now you've made this commit:
https://github.com/NodeBB/nodebb-theme-lavender/commit/7f8e9e4df0f0d20e8b83ab096c1443544df9bd4c
There is scope for the template inheritance to be used there instead of the hardcoded rule 'nodebb-theme-vanilla/templates'?

Right now I'm maintaining an entire theme that's a fork of lavender just so I can restyle one or two pages.