[nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed

PitaJ

It works just fine on v1.7.2

Michael Pfaff

@pitaj said in [nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed:

It works just fine on v1.7.2

Great I’ll check it out!

absurdsmash

@PitaJ my community would like to see names of attendees instead of avatars, as well as a the total number of Yes/No/Maybe. How would I go about implementing this?

Edit:

So I guess in client/responses.js, change this:

  const userTemplate = user => (`
    <li class="icon pull-left">
      <a href="${config.relative_path}/user/${user.userslug}">
        ${user.picture ? `
        <img title="${user.username}" class="img-rounded user-img not-responsive"
          src="${user.picture}">
        ` : `
        <div class="user-icon user-img" style="background-color: ${user['icon:bgColor']};"
          title="${user.username}">${user['icon:text']}</div>
        `}
      </a>
    </li>
  `);

into something like this?

  const userTemplate = user => (`
    <li>
      <a href="${config.relative_path}/user/${user.userslug}">
         ${user.username}
      </a>
    </li>
  `);

of course it would be awesome to have this as an option in the acp

PitaJ

@absurdsmash would you mind opening an issue on GitHub? It helps me track feature request more easily.

Alex Galax

First of all - great plugin!

I forked the plugin. But the intallation npm i <myGhUsername>/nodebb-plugin-calendar won't create the ./build build.

I want to do some changes on the templates. Whats the best practice for this?

PitaJ

@alex-galax the best way to override templates is probably to create a new plugin with a templates directory and a plugin.json set to {}. You can override the templates that way if you copy the calendar templates over.

Alex Galax

@pitaj but I can't do it in my custom theme, because its getting build first, right?

PitaJ

@alex-galax right, your custom theme is lowest priority.

Alex Galax

@pitaj hmm, the html code for displaying an event in the topic ist done in /src/lib/template.js. So can't really overwrite this way, right?

PitaJ

@alex-galax Hmm, yeah I guess not. What exactly do you want to change? Maybe it can be accomplished with CSS?

Alex Galax

@pitaj want to change the panel layout. shure, could be done in css but its not neat
best thing for my layout would be the event as a seperate post component. and for that I need to change the plugin anyways. but i still have no idea, why the fork won't install correctly

PitaJ

@alex-galax Using CSS would be a lot better from a maintainability standpoint. What do you mean by a separate post component?

Alex Galax

@pitaj that's true. I will try how far I come with pure css.
I mean, I'd like to have it as a <li component="post" element. Why isn't that html code parsed as a tpl anyways?

PitaJ

@alex-galax having it display as a post is going to be more difficult than you might think. It will require changing now things that just the calendar plugin I think.

I used a JS template because I was using some pretty complex logic and using a normal template would have been pretty verbose. With benchpress now, though, I'll look into switching back.

Alex Galax

@pitaj yeah I can imagine its not that easy. I'd probably extend data.postData.event = {...} and go from there. For now I found a css only solution.

Alex Galax

@pitaj said in [nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed:

@alex-galax the best way to override templates is probably to create a new plugin with a templates directory and a plugin.json set to {}. You can override the templates that way if you copy the calendar templates over.

~~I created the plugin with the following structure.~~

nodebb-plugin-ns-theme/
├── templates/
│   └── calendar.tpl
├── package.json
└── plugin.json

plugin.json is an empty object and calendar.tpl has only some text for testing. I activated the plugin, set its position below calendar in the apc sorting settings and build everything. But its still the old calendar

it's working now. did it with a regular plugin setup.

azeus

Hi @pitaj is it working on 1.7.4 ? Cause it doesn't on my forum I upgraded from 1.5.0 to 1.5.3 then to 1.6.0 then to 1.7.4. Then the calendar wasn't installed at all after the upgrade, I had to install it again, and now when we click on it nothing happen. It just keep waiting.... Please advise.

PitaJ

@azeus it's working here for me on v1.7.5, is the calendar plugin included in the dependencies list in package.json? Are there any errors client or server side? Have you tried ./nodebb build?

azeus

@pitaj Thanks, I'm running 1.7.5 as well. It was saying something about package.json missing when I run npm i but I just ignored it before upgrading nodebb, maybe a big mistake?

I tried ./nodebb build now the calendar is back but still have problem with emojies not showing, any idea?

$ npm i
npm WARN saveError ENOENT: no such file or directory, open '/var/www/regards/package.json'
npm WARN enoent ENOENT: no such file or directory, open '/var/www/regards/package.json'
npm WARN regards No description
npm WARN regards No repository field.
npm WARN regards No README data
npm WARN regards No license field.

PitaJ

@azeus it looks like either you aren't running npm i inside the nodebb directory, or you are running it before running ./nodebb upgrade. What problems are you having with emojis not showing?