[nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed

PitaJ

It pops up a preview of the event and you can click on the "go to post" button.

jtsimoes

@PitaJ Ohhhh... I didn't know that because nothing appeared to me, but now I see that there some problem and that's the reason why it does not appear the preview

templates.js:13 

Uncaught TypeError: event.reminders.sort is not a function
    at eventTemplate (templates.js:13)
    at displayEvent (displayEvent.js:5)
    at HTMLAnchorElement.eventClick (index.js:40)
    at Calendar.publiclyTrigger (fullcalendar.js:9352)
    at SubClass.DateComponent.publiclyTrigger (fullcalendar.js:8780)
    at EventPointing.handleClick (fullcalendar.js:6599)
    at HTMLAnchorElement.<anonymous> (fullcalendar.js:3352)
    at HTMLDivElement.dispatch (jquery.js:5183)
    at HTMLDivElement.g.handle (jquery.js:4991)

PitaJ

@jtsimoes tracking here:

Error when viewing events · Issue #111 · pitaj/nodebb-plugin-calendar

Stack trace: templates.js:13 Uncaught TypeError: event.reminders.sort is not a function at eventTemplate (templates.js:13) at displayEvent (displayEvent.js:5) at HTMLAnchorElement.eventClick (index.js:40) at Calendar.publiclyTrigger (ful...

GitHub (github.com)

PitaJ

New version. Please try out [email protected]
Note: this version requires NodeBB v1.10.0

npm i nodebb-plugin-calendar@latest

Changelog:

Fix the "Link the permission to respond to an event to the reply permission" setting to work correctly
Fix not being able to save an event with reminders
Fix reminders not rendering correctly
Fix issue with the date picker library not being loaded

If you have issues after updating, try editing and saving any posts with events in them, that may fix the problems you're seeing.

jtsimoes

@PitaJ Awesome! Many thanks, it's working perfectly until now!

Fix the "Link the permission to respond to an event to the reply permission" setting to work correctly [Not checked yet]
Fix not being able to save an event with reminders [FIXED]
Fix reminders not rendering correctly [FIXED]
Fix issue with the date picker library not being loaded [FIXED]

Just this minor things missing:

Publish this latest version on npm;
Accept my pull request to add pt-PT translation;
Add event_deleted var on calendar.json because I'm getting this warning on console log when I delete an event:

Missing translation "calendar:event_deleted"

PitaJ

@jtsimoes said in [nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed:

Just this minor things missing:

Publish this latest version on npm;

It is published.

Accept my pull request to add pt-PT translation;

There are just a couple small changes I'd like you to make first. I meant to send that feedback a few days ago but GitHub mobile is stupid.

Add event_deleted var on calendar.json because I'm getting this warning on console log when I delete an event:
Missing translation "calendar:event_deleted"

Good catch.

jtsimoes

@PitaJ said in [nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed:

It is published.

Are you sure? My NodeBB couldn't detect it:

I had to install it through npm i

There are just a couple small changes I'd like you to make first. I meant to send that feedback a few days ago but GitHub mobile is stupid.

Oh, okay! I already saw them, I'm working on

PitaJ

New version. Please try out [email protected]
Note: this version requires NodeBB v1.11.0

npm i nodebb-plugin-calendar@latest

Changelog:

Feature: New privilege for mandatory event creation. Only users with this privilege can post mandatory events
Feature: Setting for configuring the available calendar views
Bug fix: event_deleted translation no longer missing

jtsimoes

@PitaJ I tested it out now, it's all good!
It's only missing translation for the new views on the calendar page (listDay, listWeek, listMonth, and listYear):

Besides, that's all. Thanks for the new version!
Since you added the event_deleted translation, I will make a pull request very soon to add this to pt-PT language too. Or perhaps wait until you add the translations for this new views.

UPDATE:
I also noticed that the calendar_admin.json file on languages only contains translations that are not being used and are deprecated, so you could consider deleting it since it is unnecessary.

PitaJ

New version. Please try out [email protected]
Note: this version requires NodeBB v1.11.0

npm i nodebb-plugin-calendar@latest

Changelog:

List view buttons are now translated (thanks @jtsimoes)
Reminder notification daemon only runs on one process now

jtsimoes

@PitaJ Awesome, it's all perfect now! Thank you and great job.

crazycells

@PitaJ Thanks a lot for this plugin. This is perfect for us. We are an immigration forum and we have social gatherings regularly in more than 10 cities in US and Turkey... It was hard to keep track of these events in topics for some of the folks, this solved our issue.

I have a request, is it possible to make a note on calendar? It will not be an event where people go, it will just mark an important day and have a description. (For example, each month we have "visa bulletin" announced by DOS, it would be nice to add that on calendar and give direct link to the bulletin rather than a topic in the forum). In this case, of course it will have more simple look because people does not need to say yes/no/maybe...

Thanks again. Even current form of the plugin is super helpful.

mrb

Hello

It's great the event background colour matches the category it was posted in. However, is it possible for the event's text colour to match the category too?

The category I use for event posts has a bright yellow background with black text. Since it seems calendar events always use white text, it means the event text can't be read.

Thanks for a great plugin though!

PitaJ

@mrb I don't see that being terribly difficult. Please open an issue on GitHub

mrb

@PitaJ Done, thanks.

Fl4shBack51

Hi @PitaJ !

Sorry for bothering you !

Whenever I'm building the plugin myself (I tried to build both your version and my altered version), user avatars in response-lists are not working anymore, do you have any tips ? I'm no JS pro so I'm quite overwhelmed

I'm trying to integrate a discord webhook to post events on our discord server whenever we are creating an event.

Source code is here https://github.com/fl4shback/nodebb-plugin-calendar/tree/discord-integration if you want to take a look at it.

Thank you

PitaJ

@Fl4shBack51 what version of NodeBB are you on?

Fl4shBack51

@PitaJ
1.12.2

Fl4shBack51

@PitaJ Hey !

just to keep you updated, I solved the issue by reverting the changes made by the latest commit (which isn't included in the 50 release) https://github.com/pitaj/nodebb-plugin-calendar/commit/592f41690437acc502ca21b95eeed4e5e0d186cf

Now I'm able to do my edits and build the plugin juste fine and everything works!

PitaJ

@Fl4shBack51 what theme are you using? It is the latest version?