[nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed

PitaJ

@azeus it's working here for me on v1.7.5, is the calendar plugin included in the dependencies list in package.json? Are there any errors client or server side? Have you tried ./nodebb build?

azeus

@pitaj Thanks, I'm running 1.7.5 as well. It was saying something about package.json missing when I run npm i but I just ignored it before upgrading nodebb, maybe a big mistake?

I tried ./nodebb build now the calendar is back but still have problem with emojies not showing, any idea?

$ npm i
npm WARN saveError ENOENT: no such file or directory, open '/var/www/regards/package.json'
npm WARN enoent ENOENT: no such file or directory, open '/var/www/regards/package.json'
npm WARN regards No description
npm WARN regards No repository field.
npm WARN regards No README data
npm WARN regards No license field.

PitaJ

@azeus it looks like either you aren't running npm i inside the nodebb directory, or you are running it before running ./nodebb upgrade. What problems are you having with emojis not showing?

azeus

@pitaj It was before the upgrade tks. Emojis are fixed now, I had to install the emojies plugins (android, apple, cubicopp, extended, one, static) and now it working.

The calendar is working as well after the ./nodebb build

Thanks again

Kev M

@evoixmr thanks for this. I'm glad this exists.

@Pitaj thank you for your work on this! Is it possible to have calendars by group? So if our marketing team wanted a calendar with their events, and our comms team wanted a different calendar for their events, does that exist?

PitaJ

@kev-m calendar events have permissions according to the category they're posted in. So, you can create a category for the marketing events, and a category for the comms events, and set the permissions accordingly. The color of the events on the calendar will match that of the categories.

azeus

@pitaj is it working with v1.8.0?

PitaJ

New version. Please try out [email protected]
Note: this version requires NodeBB v1.10.0

npm i nodebb-plugin-calendar@latest

Changelog:

Only supports modern browsers and Node 10+ now
Update dependencies
Polish language translations
Convert event and responses template to use benchpress templates, so they can be overridden by themes or other plugins
Handle HTML entities better
Lazy loading to reduce bundle burden when not using calendar or viewing events
Don't show events in post previews / topic teasers

PitaJ

New version. Please try out [email protected]
Note: this version requires NodeBB v1.10.0

npm i nodebb-plugin-calendar@latest

Changelog:

Fix post delete hook: no longer crashes NodeBB when deleting posts
Added post restore and post purge hooks, so event is only fully deleted on the post purge

jtsimoes

@PitaJ It would be a good feature for this plugin if, on the /calendar page, when you clicked on an event, it would take you to the post where it was created.
I think it's reasonably easy to do, right?

PitaJ

It pops up a preview of the event and you can click on the "go to post" button.

jtsimoes

@PitaJ Ohhhh... I didn't know that because nothing appeared to me, but now I see that there some problem and that's the reason why it does not appear the preview

templates.js:13 

Uncaught TypeError: event.reminders.sort is not a function
    at eventTemplate (templates.js:13)
    at displayEvent (displayEvent.js:5)
    at HTMLAnchorElement.eventClick (index.js:40)
    at Calendar.publiclyTrigger (fullcalendar.js:9352)
    at SubClass.DateComponent.publiclyTrigger (fullcalendar.js:8780)
    at EventPointing.handleClick (fullcalendar.js:6599)
    at HTMLAnchorElement.<anonymous> (fullcalendar.js:3352)
    at HTMLDivElement.dispatch (jquery.js:5183)
    at HTMLDivElement.g.handle (jquery.js:4991)

PitaJ

@jtsimoes tracking here:

Error when viewing events · Issue #111 · pitaj/nodebb-plugin-calendar

Stack trace: templates.js:13 Uncaught TypeError: event.reminders.sort is not a function at eventTemplate (templates.js:13) at displayEvent (displayEvent.js:5) at HTMLAnchorElement.eventClick (index.js:40) at Calendar.publiclyTrigger (ful...

GitHub (github.com)

PitaJ

New version. Please try out [email protected]
Note: this version requires NodeBB v1.10.0

npm i nodebb-plugin-calendar@latest

Changelog:

Fix the "Link the permission to respond to an event to the reply permission" setting to work correctly
Fix not being able to save an event with reminders
Fix reminders not rendering correctly
Fix issue with the date picker library not being loaded

If you have issues after updating, try editing and saving any posts with events in them, that may fix the problems you're seeing.

jtsimoes

@PitaJ Awesome! Many thanks, it's working perfectly until now!

Fix the "Link the permission to respond to an event to the reply permission" setting to work correctly [Not checked yet]
Fix not being able to save an event with reminders [FIXED]
Fix reminders not rendering correctly [FIXED]
Fix issue with the date picker library not being loaded [FIXED]

Just this minor things missing:

Publish this latest version on npm;
Accept my pull request to add pt-PT translation;
Add event_deleted var on calendar.json because I'm getting this warning on console log when I delete an event:

Missing translation "calendar:event_deleted"

PitaJ

@jtsimoes said in [nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed:

Just this minor things missing:

Publish this latest version on npm;

It is published.

Accept my pull request to add pt-PT translation;

There are just a couple small changes I'd like you to make first. I meant to send that feedback a few days ago but GitHub mobile is stupid.

Add event_deleted var on calendar.json because I'm getting this warning on console log when I delete an event:
Missing translation "calendar:event_deleted"

Good catch.

jtsimoes

@PitaJ said in [nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed:

It is published.

Are you sure? My NodeBB couldn't detect it:

I had to install it through npm i

There are just a couple small changes I'd like you to make first. I meant to send that feedback a few days ago but GitHub mobile is stupid.

Oh, okay! I already saw them, I'm working on

PitaJ

New version. Please try out [email protected]
Note: this version requires NodeBB v1.11.0

npm i nodebb-plugin-calendar@latest

Changelog:

Feature: New privilege for mandatory event creation. Only users with this privilege can post mandatory events
Feature: Setting for configuring the available calendar views
Bug fix: event_deleted translation no longer missing

jtsimoes

@PitaJ I tested it out now, it's all good!
It's only missing translation for the new views on the calendar page (listDay, listWeek, listMonth, and listYear):

Besides, that's all. Thanks for the new version!
Since you added the event_deleted translation, I will make a pull request very soon to add this to pt-PT language too. Or perhaps wait until you add the translations for this new views.

UPDATE:
I also noticed that the calendar_admin.json file on languages only contains translations that are not being used and are deprecated, so you could consider deleting it since it is unnecessary.

PitaJ

New version. Please try out [email protected]
Note: this version requires NodeBB v1.11.0

npm i nodebb-plugin-calendar@latest

Changelog:

List view buttons are now translated (thanks @jtsimoes)
Reminder notification daemon only runs on one process now