[nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed

azeus

@PitaJ said in [nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed:

Changes:

Minor visual fixes
Possible fix for unexpected token error with repeated events

Still Unexpected token “ with 0.18. But repeating events is a nice to have for us so no problem, we just want to avoid the users to create this cause it crashes the forum... Otherwise, the plugin is up and running in our production and we are happy with it

PitaJ

@azeus can you try [email protected]? Thanks.

Just FYI: it might make some events invalid. Let me know if this is a widespread thing. It shouldn't be, it should only affect repeating events that were created with previous versions.

If you want to save those events (they might just show as bbcode-ish markup), just delete the [repeats]...[/repeats] section

azeus

@PitaJ Ok no error with v0.19 and repeating events are showing fine in the calendar but not in the post. Raw code is displayed as text instead.

0_1479302478773_upload-e0c986af-8a57-439e-828e-9ee90ebe4cc6

PitaJ

@azeus is that a new event you created after updating, or an older one? If it's an older one that you want to save just delete the [repeats]....[/repeats] part and edit it normally with the composer button.

If it's not an older one, then I'm having trouble reproducing.

azeus

@PitaJ It's a new event... Removing the [repeats] dosn't fix... You can reproduce in my dev ^^

Nikolai Bochev

Hey,

I am trying this on a fresh 1.3.0 install, and it initially works, but after some time the calendar interface on "New Post" won't open. No errors in ./nodebb log, so i fired up the firefox devtools and got the following:

Translation failed: n   @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838:47:16079
t.fn.datetimepicker     @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838:47:16875
.each                   @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838:1:2988
p.prototype.each        @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838:1:1077
t.fn.datetimepicker     @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838:47:16740
e.show                  @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838:45:6130
g                       @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838:11:381
t                       @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838:50:3006
notify.run              @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838 line 25 > eval:87:22
notify                  @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838 line 25 > eval:100:28
module.exports/flush    @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838 line 17 > eval:18:9
nodebb.min.js:50:3031

Any ideas what's wrong ?

PitaJ

@Nikolai-Bochev hi, thanks for the report. can you explain a little more about the context? When did this error occur? Was it on a page with a certain event, and if so, what was the "source code" for the post? Is your site publicly available, I'd like to test it out if possible.

Nikolai Bochev

@PitaJ said in [nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed:

@Nikolai-Bochev hi, thanks for the report. can you explain a little more about the context? When did this error occur? Was it on a page with a certain event, and if so, what was the "source code" for the post? Is your site publicly available, I'd like to test it out if possible.

Hey,

It is when you click on the calendar icon on new post, to create an event and the UI does not open at all. There is no other event displayed at the time.
The forum is still on testing period. It's at:

http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/

You should be able to register without email confirmation and i have allowed calendar even creation in General Discussion. If required i can give you ssh access to the VM as well.

PitaJ

@Nikolai-Bochev okay I've made a change that should fix your issue.

npm install [email protected]

Thanks for testing it out!

Nikolai Bochev

@PitaJ said in [nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed:

@Nikolai-Bochev okay I've made a change that should fix your issue.
npm install [email protected]
Thanks for testing it out!

Problem solved, thanks for being so fast !

evoixmr

@PitaJ Can the repeat be set up like "every 1st or 2nd" friday of the month?

The selection button is blocking some words.

evoixmr

@PitaJ On the email notification, the button does not work. Can there an option to invite? same as metion but they will get email notification to respond?

PitaJ

@evoixmr it looks like the CSS is kinda messed up. What browser are you on?

I do plan on introducing more custom repeat options.

Oh, oops. Didn't mean to show the response thing in the email.

The invite thing sounds interesting. I'd like to keep it restricted to inviting existing users.

evoixmr

@PitaJ I'm using firefox on linux. Yes inviting members would be a nice option.

PitaJ

@evoixmr okay I fixed the issue. Upgrade to [email protected] .

evoixmr

@PitaJ Upgraded thanks. Now waiting for more custom repeat option and member invitation.

evoixmr

@PitaJ I have some events that the guest need to be able to see and some that I need hidden from guest. Does the calendar follow nodebb permission?

PitaJ

@evoixmr yeah it obeys either the view or reply permission, depending on the setting in the ACP.

evoixmr

@PitaJ For some reason I can't make the calendar viewable to guest, but they have to login to be able to reply. Can you make the calendar follow the view permission?

PitaJ

@evoixmr what version are you on? I may have accidentally introduced a regression in a previous version.