[nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed

PitaJ

@azeus okay so we thought up similar things. The only real difference is that you keep the maybe option.

I don't really think the maybe option makes sense when there's a limited number of slots for a certain event.

Does a person who responds with maybe get put on the reservation list or on the waiting list, assuming there are open slots? Does a person who responds maybe before another person responds yes get priority in the waiting list, or do people who respond with yes get priority over all maybes in the waiting list?

When you're just gauging attention or counting RSVPs, a response of yes, maybe, or no makes sense. But if you're providing a first come first serve opportunity, maybe doesn't make sense, in my opinion.

I'm open to having the third option but as of now I'm not convinced.

azeus

@PitaJ said in [nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed:

Does a person who responds with maybe get put on the reservation list or on the waiting list, assuming there are open slots?

He's put on the "Maybe list" which is different from "Reservation list" and "Waiting list'. Actually there are 3 lists.

Does a person who responds maybe before another person responds yes get priority in the waiting list, or do people who respond with yes get priority over all maybes in the waiting list?

"Yes" (or reservation list) is the priority, and it's an automated action, when a sol is available the fits one in the "Waiting list" takes the place. The people in the "maybe list" stays in the 'maybe' list until they change their mind.

When you're just gauging attention or counting RSVPs, a response of yes, maybe, or no makes sense. But if you're providing a first come first serve opportunity, maybe doesn't make sense, in my opinion.

I'm open to having the third option but as of now I'm not convinced.

Your first proposal with only 2 options is fine for us What we proposed is our nice to have, that fits 100% our need.

Actually the whole idea about keeping the "Maybe", is that we know that our users don't know their planning in advance, and we are publishing our events mounts before the D date... Most of our users didn't confirm directly because they don't know if they are available... So if we have only 2 options "Yes" and "No", we think that most of them will click "No" or just does nothing... And then they will forget about the whole thing and never come back ^^ With the 'maybe' option, they keep event notifications and they keep tracking ....

PitaJ

@azeus

Actually the whole idea about keeping the "Maybe", is that we know that our users don't know their planning in advance, and we are publishing our events mounts before the D date... Most of our users didn't confirm directly because they don't know if they are available... So if we have only 2 options "Yes" and "No", we think that most of them will click "No" or just does nothing... And then they will forget about the whole thing and never come back ^^ With the 'maybe' option, they keep event notifications and they keep tracking ....

So maybe doesn't really serve any purpose besides a way for users to be reminded of the event before it starts? Hmmm. Well at the moment, Maybe doesn't get any notifications except when the event starts. Perhaps change the three buttons to:

[ + Reservation ] [ Remind me ] [ No ]

And then when all reservations are full:

[ + Waiting list ] [ Remind me ] [ No ]

azeus

@PitaJ said in [nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed:
Perhaps change the three buttons to:

[ + Reservation ] [ Remind me ] [ No ]

And then when all reservations are full:

[ + Waiting list ] [ Remind me ] [ No ]

Definitely yes, that makes sens and it's a simpler solution Go for that ^^

azeus

@PitaJ ~~Hello, Nodebb v1.3.0 is out, are we safe to go there with Calendar v0.13?~~

Well already moved to 1.3.0, it's maybe not yet the version needed for Calendar 0.13 ?

$ git rev-parse HEAD
4db89407c4dbe9850d925bd9529a1d106419531f

NodeBB is rebooting with error messages:

{"level":"error","message":"TypeError: Cannot read property 'pid' of null\n    at pluginSockets.calendar.canPostEvent
/async.js:746:34)\n    at /var/www/regards.photo/node_modules/async/lib/async.js:1213:16\n    at /var/www/regards.pho
to/node_modules/async/lib/async.js:1206:34)\n    at processImmediate [as _immediateCallback] (timers.js:383:17)","tim
estamp":"2016-11-14T14:11:35.472Z"}
TypeError: Cannot read property 'pid' of null
    at pluginSockets.calendar.canPostEvent (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/src/lib/socket
s.js:33:83)
    at async.waterfall.err.message (/var/www/regards.photo/src/socket.io/index.js:117:5)
    at fn (/var/www/regards.photo/node_modules/async/lib/async.js:746:34)
    at /var/www/regards.photo/node_modules/async/lib/async.js:1213:16
    at /var/www/regards.photo/node_modules/async/lib/async.js:166:37
    at /var/www/regards.photo/node_modules/async/lib/async.js:706:43
    at /var/www/regards.photo/node_modules/async/lib/async.js:167:37
    at Immediate._onImmediate (/var/www/regards.photo/node_modules/async/lib/async.js:1206:34)
    at processImmediate [as _immediateCallback] (timers.js:383:17)
{"level":"info","message":"[app] Shutdown (SIGTERM/SIGINT) Initialised.","timestamp":"2016-11-14T14:11:35.473Z"}
{"level":"info","message":"[app] Database connection closed.","timestamp":"2016-11-14T14:11:35.476Z"}
{"level":"info","message":"[app] Web server closed to connections.","timestamp":"2016-11-14T14:11:35.477Z"}
{"level":"info","message":"[app] Shutdown complete.","timestamp":"2016-11-14T14:11:35.477Z"}
[cluster] Child Process (1823) has exited (code: 1, signal: null)
[cluster] Spinning up another process...
{"level":"info","message":"Time: Mon Nov 14 2016 15:11:36 GMT+0100 (CET)","timestamp":"2016-11-14T14:11:36.005Z"}

we have deactivated the plugin as a workaround ^^

PitaJ

@azeus v1.3.0 should be fine for Calendar alpha.13

I know what causes that error to occur but I don't know what the origin of that error is. As far as I can tell, it's caused by somebody's computer being slow and not finishing a rendering cycle before the delay I put in finishes. I've put in a safeguard so at least it won't crash from now on.

PitaJ

New version. Please update to [email protected].
This version requires NodeBB v1.3.0.

npm install nodebb-plugin-calendar@latest

Changes:

Improve event popup on calendar page
Show events starting before and ending after month in calendar view

azeus

@PitaJ said in [nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed:

npm install nodebb-plugin-calendar@latest

Tks but it's still rebooting ...

{"level":"error","message":"TypeError: Cannot read property 'pid' of undefined\n at /var/www/regards.photo/src/posts/create.js:63:36\n at fn (/var/www/regards.photo/node_modules/async/lib/async.js:746:34)\n at /var/www/regards.photo/node_modules/async/lib/async.js:1213:16\n at /var/www/regards.photo/node_modules/async/lib/async.js:166:37\n at /var/www/regards.photo/node_modules/async/lib/async.js:706:43\n at /var/www/regards.photo/node_modules/async/lib/async.js:167:37\n at /var/www/regards.photo/node_modules/async/lib/async.js:1209:30\n at /var/www/regards.photo/src/plugins/hooks.js:120:4\n at /var/www/regards.photo/node_modules/async/lib/async.js:380:13\n at /var/www/regards.photo/node_modules/async/lib/async.js:52:16\n at /var/www/regards.photo/node_modules/async/lib/async.js:269:32\n at /var/www/regards.photo/node_modules/async/lib/async.js:44:16\n at /var/www/regards.photo/node_modules/async/lib/async.js:377:17\n at tryCatcher (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/util.js:16:23)\n at Promise.successAdapter [as _fulfillmentHandler0] (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/nodeify.js:23:30)\n at Promise._settlePromise (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/promise.js:564:21)\n at Promise._settlePromise0 (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/promise.js:612:10)\n at Promise._settlePromises (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/promise.js:691:18)\n at Async._drainQueue (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/async.js:138:16)\n at Async._drainQueues (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/async.js:148:10)\n at Immediate.Async.drainQueues [as _onImmediate] (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/async.js:17:14)\n at processImmediate [as _immediateCallback] (timers.js:383:17)","timestamp":"2016-11-14T23:57:50.288Z"}
TypeError: Cannot read property 'pid' of undefined
at /var/www/regards.photo/src/posts/create.js:63:36
at fn (/var/www/regards.photo/node_modules/async/lib/async.js:746:34)
at /var/www/regards.photo/node_modules/async/lib/async.js:1213:16
at /var/www/regards.photo/node_modules/async/lib/async.js:166:37
at /var/www/regards.photo/node_modules/async/lib/async.js:706:43
at /var/www/regards.photo/node_modules/async/lib/async.js:167:37
at /var/www/regards.photo/node_modules/async/lib/async.js:1209:30
at /var/www/regards.photo/src/plugins/hooks.js:120:4
at /var/www/regards.photo/node_modules/async/lib/async.js:380:13
at /var/www/regards.photo/node_modules/async/lib/async.js:52:16
at /var/www/regards.photo/node_modules/async/lib/async.js:269:32
at /var/www/regards.photo/node_modules/async/lib/async.js:44:16
at /var/www/regards.photo/node_modules/async/lib/async.js:377:17
at tryCatcher (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/util.js:16:23)
at Promise.successAdapter [as _fulfillmentHandler0] (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/nodeify.js:23:30)
at Promise._settlePromise (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/promise.js:564:21)
at Promise._settlePromise0 (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/promise.js:612:10)
at Promise._settlePromises (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/promise.js:691:18)
at Async._drainQueue (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/async.js:138:16)
at Async._drainQueues (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/async.js:148:10)
at Immediate.Async.drainQueues [as _onImmediate] (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/async.js:17:14)
at processImmediate [as _immediateCallback] (timers.js:383:17)
{"level":"info","message":"[app] Shutdown (SIGTERM/SIGINT) Initialised.","timestamp":"2016-11-14T23:57:50.292Z"}
{"level":"info","message":"[app] Database connection closed.","timestamp":"2016-11-14T23:57:50.294Z"}
{"level":"info","message":"[app] Web server closed to connections.","timestamp":"2016-11-14T23:57:50.294Z"}
{"level":"info","message":"[app] Shutdown complete.","timestamp":"2016-11-14T23:57:50.295Z"}
[cluster] Child Process (5013) has exited (code: 1, signal: null)
[cluster] Spinning up another process...
{"level":"info","message":"Time: Tue Nov 15 2016 00:57:50 GMT+0100 (CET)","timestamp":"2016-11-14T23:57:50.845Z"}
{"level":"info","message":"Initializing NodeBB v1.3.0","timestamp":"2016-11-14T23:57:50.848Z"}
{"level":"info","message":"[database] Checking database indices.","timestamp":"2016-11-14T23:57:51.218Z"}
{"level":"info","message":"[database] Checking database indices done!","timestamp":"2016-11-14T23:57:51.243Z"}
{"level":"info","message":"initializing NodeBB ...","timestamp":"2016-11-14T23:57:52.346Z"}
{"level":"warn","message":"[plugins/nodebb-plugin-poll] Hook filter:post.save is deprecated, please use filter:post.create instead.","timestamp":"2016-11-14T23:57:52.620Z"}
Notifier Daemon initialized with
interval of 300 seconds
{"level":"info","message":"Routes added","timestamp":"2016-11-14T23:57:53.603Z"}
{"level":"info","message":"NodeBB Ready","timestamp":"2016-11-14T23:58:06.651Z"}
{"level":"info","message":"Enabling 'trust proxy'","timestamp":"2016-11-14T23:58:06.658Z"}
{"level":"info","message":"NodeBB is now listening on: 0.0.0.0:8080","timestamp":"2016-11-14T23:58:06.663Z"}
{"level":"error","message":"TypeError: Cannot read property 'pid' of undefined\n at /var/www/regards.photo/src/posts/create.js:63:36\n at fn (/var/www/regards.photo/node_modules/async/lib/async.js:746:34)\n at /var/www/regards.photo/node_modules/async/lib/async.js:1213:16\n at /var/www/regards.photo/node_modules/async/lib/async.js:166:37\n at /var/www/regards.photo/node_modules/async/lib/async.js:706:43\n at /var/www/regards.photo/node_modules/async/lib/async.js:167:37\n at /var/www/regards.photo/node_modules/async/lib/async.js:1209:30\n at /var/www/regards.photo/src/plugins/hooks.js:120:4\n at /var/www/regards.photo/node_modules/async/lib/async.js:380:13\n at /var/www/regards.photo/node_modules/async/lib/async.js:52:16\n at /var/www/regards.photo/node_modules/async/lib/async.js:269:32\n at /var/www/regards.photo/node_modules/async/lib/async.js:44:16\n at /var/www/regards.photo/node_modules/async/lib/async.js:377:17\n at tryCatcher (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/util.js:16:23)\n at Promise.successAdapter [as _fulfillmentHandler0] (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/nodeify.js:23:30)\n at Promise._settlePromise (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/promise.js:564:21)\n at Promise._settlePromise0 (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/promise.js:612:10)\n at Promise._settlePromises (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/promise.js:691:18)\n at Async._drainQueue (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/async.js:138:16)\n at Async._drainQueues (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/async.js:148:10)\n at Immediate.Async.drainQueues [as _onImmediate] (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/async.js:17:14)\n at processImmediate [as _immediateCallback] (timers.js:383:17)","timestamp":"2016-11-14T23:58:10.894Z"}
TypeError: Cannot read property 'pid' of undefined
at /var/www/regards.photo/src/posts/create.js:63:36
at fn (/var/www/regards.photo/node_modules/async/lib/async.js:746:34)
at /var/www/regards.photo/node_modules/async/lib/async.js:1213:16
at /var/www/regards.photo/node_modules/async/lib/async.js:166:37
at /var/www/regards.photo/node_modules/async/lib/async.js:706:43
at /var/www/regards.photo/node_modules/async/lib/async.js:167:37
at /var/www/regards.photo/node_modules/async/lib/async.js:1209:30
at /var/www/regards.photo/src/plugins/hooks.js:120:4
at /var/www/regards.photo/node_modules/async/lib/async.js:380:13
at /var/www/regards.photo/node_modules/async/lib/async.js:52:16
at /var/www/regards.photo/node_modules/async/lib/async.js:269:32
at /var/www/regards.photo/node_modules/async/lib/async.js:44:16
at /var/www/regards.photo/node_modules/async/lib/async.js:377:17
at tryCatcher (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/util.js:16:23)
at Promise.successAdapter [as _fulfillmentHandler0] (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/nodeify.js:23:30)
at Promise._settlePromise (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/promise.js:564:21)
at Promise._settlePromise0 (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/promise.js:612:10)
at Promise._settlePromises (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/promise.js:691:18)
at Async._drainQueue (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/async.js:138:16)
at Async._drainQueues (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/async.js:148:10)
at Immediate.Async.drainQueues [as _onImmediate] (/var/www/regards.photo/node_modules/nodebb-plugin-calendar/node_modules/bluebird/js/release/async.js:17:14)
at processImmediate [as _immediateCallback] (timers.js:383:17)
{"level":"info","message":"[app] Shutdown (SIGTERM/SIGINT) Initialised.","timestamp":"2016-11-14T23:58:10.897Z"}
{"level":"info","message":"[app] Database connection closed.","timestamp":"2016-11-14T23:58:10.898Z"}
{"level":"info","message":"[app] Web server closed to connections.","timestamp":"2016-11-14T23:58:10.899Z"}
{"level":"info","message":"[app] Shutdown complete.","timestamp":"2016-11-14T23:58:10.899Z"}
[cluster] Child Process (5062) has exited (code: 1, signal: null)

PitaJ

@azeus

New version. Please update to [email protected].
This version requires NodeBB v1.3.0.

npm install nodebb-plugin-calendar@latest

Changes:

Fixed NodeBB crashing when no event was posted

Edit: Also, figured I'd let everyone know that I'm making good progress on implementing repeating events. All that's really left is reminders for repeating events, some other forms of custom repetition, and responses for repeated events.

PitaJ

New version. Please try out [email protected]
This version requires NodeBB v1.3.0

npm install nodebb-plugin-calendar@latest

Changes:

Repeating events!!!!!!

azeus

@PitaJ Tks a lot man, I've installed v0.16, it crashes less but still crashs... And the calendar icon in the composer does nothing... I'll update to 0.17 and let you know

EDIT: V0.17 no crash for the moment (crossing fingers ^^ ), 2 issues:

When trying a repeating event I'm having an error "Unexpected token " and in the logs >>> {"level":"error","message":"[plugins] filter:parse.raw, Unexpected token “","timestamp":"2016-11-15T08:15:22.148Z"}
When clicking the calendar view (icon in the navigation bar), the4 buttons 'Month' 'Week' 'Day' 'Show only YES' are not showing... We need to click twice and then the page is reloaded and just then the buttons are showing again >>> cleaned the cache and seems to be OK

PitaJ

@azeus is that only with a custom repeating event by chance? One with a specified end date and not repeating forever?

azeus

@PitaJ said in [nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed:

@azeus is that only with a custom repeating event by chance? One with a specified end date and not repeating forever?

Actually I got the error what ever the option is. The error is displayed and we can't validate the event creation... But still, the event is created in the calendar... After this, we've a big issue in the whole forum... Now everything is broken Any idea how to fix? tks

Internal Error.
Oops! Looks like something went wrong!
/categories
Unexpected token “

Edit: Fixed: I've disabled the calendar plugin from ACP, then removed the repeating event that I've created before, then I've reactivated the pluging again. Now it's fixed ^^ But the repeating events is definitely not working yet

PitaJ

@azeus New version. Please try out [email protected]

npm install nodebb-plugin-calendar@latest

Changes:

Minor visual fixes
Possible fix for unexpected token error with repeated events

azeus

@PitaJ said in [nodebb-plugin-calendar] Fully featured calendar plugin for NodeBB - Testers needed:

Changes:

Minor visual fixes
Possible fix for unexpected token error with repeated events

Still Unexpected token “ with 0.18. But repeating events is a nice to have for us so no problem, we just want to avoid the users to create this cause it crashes the forum... Otherwise, the plugin is up and running in our production and we are happy with it

PitaJ

@azeus can you try [email protected]? Thanks.

Just FYI: it might make some events invalid. Let me know if this is a widespread thing. It shouldn't be, it should only affect repeating events that were created with previous versions.

If you want to save those events (they might just show as bbcode-ish markup), just delete the [repeats]...[/repeats] section

azeus

@PitaJ Ok no error with v0.19 and repeating events are showing fine in the calendar but not in the post. Raw code is displayed as text instead.

0_1479302478773_upload-e0c986af-8a57-439e-828e-9ee90ebe4cc6

PitaJ

@azeus is that a new event you created after updating, or an older one? If it's an older one that you want to save just delete the [repeats]....[/repeats] part and edit it normally with the composer button.

If it's not an older one, then I'm having trouble reproducing.

azeus

@PitaJ It's a new event... Removing the [repeats] dosn't fix... You can reproduce in my dev ^^

Nikolai Bochev

Hey,

I am trying this on a fresh 1.3.0 install, and it initially works, but after some time the calendar interface on "New Post" won't open. No errors in ./nodebb log, so i fired up the firefox devtools and got the following:

Translation failed: n   @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838:47:16079
t.fn.datetimepicker     @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838:47:16875
.each                   @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838:1:2988
p.prototype.each        @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838:1:1077
t.fn.datetimepicker     @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838:47:16740
e.show                  @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838:45:6130
g                       @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838:11:381
t                       @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838:50:3006
notify.run              @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838 line 25 > eval:87:22
notify                  @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838 line 25 > eval:100:28
module.exports/flush    @http://fa5a806a-bfa4-4947-88ea-c1abbcacc14d.pub.cloud.scaleway.com:4567/nodebb.min.js?343a5597-8042-49c2-a327-858c58c47838 line 17 > eval:18:9
nodebb.min.js:50:3031

Any ideas what's wrong ?