CPU utilization increased in 0.6.x

hek

Hi! Just took the leap to 0.6.x. A few thing I have noticed.

First time sitemap.xml is accessed NodeBB crashes. Second time works fine.
CPU usage went up ~10% on a 1GB digital ocean droplet.

Screen Shot 2015-03-16 at 10.26.18.png

We get plenty of these in the log:

Error: invalid csrf token
    at verifytoken (/usr/mysensors/mysensors-forum/NodeBB/node_modules/csurf/index.js:237:11)

Number of online users has dropped from ~250 to ~60. Has timeout times been changed?

Is 0.7.x out of the question for production use?

Feedback is appreciated.

Ribesg

@hek for 4), I know that there was a change in themes that made a lot of CSRF error appear when upgrading. Somebody else should explain that better, as in the end I chosed to take a clean start (fresh v0.6.x clone and cleaned redis DB).

hek

@Ribesg

Ok, what do you men by "cleaned redis"? I can't wipe everything you know, don't think the community would appreciate that

Ribesg

@hek I used redis-cli to remove everything which was not a category, a topic, a post, a user. I had less than 20 entries for each of those things so it wasn't too hard to do by hand, of course you could automate this using some script.
Then I installed the new NodeBB normally, using that cleaned Redis DB as this instance DB. It just didn't add default categories as some where already there, but it worked. I was able to login and all posts were there.

Of course you lose everything else, configuration, plugins, etc. But I think it's better. NodeBB is still a bit early to modify it too much. Plugins just started being versioned. The only thing really worth investing time in is theming, as long as you mainly do CSS and modify few templates.

I did that on a test separate instance of course (different redis instance on different port + nodebb instance clone running on different port).

a_5mith

@hek said:

Hi! Just took the leap to 0.6.x. A few thing I have noticed.

First time sitemap.xml is accessed NodeBB crashes. Second time works fine.

CPU usage went up ~10% on a 1GB digital ocean droplet.

We get plenty of these in the log:
Error: invalid csrf token
    at verifytoken (/usr/mysensors/mysensors-forum/NodeBB/node_modules/csurf/index.js:237:11)
Number of online users has dropped from ~250 to ~60. Has timeout times been changed?

Is 0.7.x out of the question for production use?

Feedback is appreciated.

Csrf could spell an out of date theme.

If you want stability, stick with stable. I use 0.7 on my live site. And it's used here. But, wouldn't recommend it.

hek

@a_5mith

Csrf could spell an out of date theme.

Hmm.. it is running the vanilla/lavender theme specified in NodeBB/package.json for 0.6.x.

pichalite

@hek What plugins do you have installed? May be one of them is not compatible with v0.6.x

hek

No, I don't think so. We also have serious problems for Safari users on 0.6. They can't post because category is not set in the composer and the unread count does not show up.

So.. considering 0.7.x. It seems to work much better on our stage env. But I get the following warnings.

17/3 11:35 [13459] - warn: [plugins/nodebb-plugin-emoji-extended] This plugin may not be compatible with your version of NodeBB. This may cause unintended behaviour or crashing.
17/3 11:35 [13459] - warn: [plugins/nodebb-plugin-emoji-extended] In the event of an unresponsive NodeBB caused by this plugin, run ./nodebb reset plugin="nodebb-plugin-emoji-extended".


17/3 11:35 [13459] - warn: [plugins/nodebb-plugin-soundpack-default] This plugin may not be compatible with your version of NodeBB. This may cause unintended behaviour or crashing.
17/3 11:35 [13459] - warn: [plugins/nodebb-plugin-soundpack-default] In the event of an unresponsive NodeBB caused by this plugin, run ./nodebb reset plugin="nodebb-plugin-soundpack-default".


17/3 11:35 [13459] - warn: [plugins/nodebb-plugin-markdown] This plugin may not be compatible with your version of NodeBB. This may cause unintended behaviour or crashing.
17/3 11:35 [13459] - warn: [plugins/nodebb-plugin-markdown] In the event of an unresponsive NodeBB caused by this plugin, run ./nodebb reset plugin="nodebb-plugin-markdown".


17/3 11:35 [13459] - warn: [plugins/nodebb-plugin-mentions] This plugin may not be compatible with your version of NodeBB. This may cause unintended behaviour or crashing.
17/3 11:35 [13459] - warn: [plugins/nodebb-plugin-mentions] In the event of an unresponsive NodeBB caused by this plugin, run ./nodebb reset plugin="nodebb-plugin-mentions".


17/3 11:35 [13459] - warn: [plugins/nodebb-rewards-essentials] This plugin may not be compatible with your version of NodeBB. This may cause unintended behaviour or crashing.
17/3 11:35 [13459] - warn: [plugins/nodebb-rewards-essentials] In the event of an unresponsive NodeBB caused by this plugin, run ./nodebb reset plugin="nodebb-rewards-essentials".


17/3 11:35 [13459] - warn: [plugins/nodebb-theme-lavender] This plugin may not be compatible with your version of NodeBB. This may cause unintended behaviour or crashing.
17/3 11:35 [13459] - warn: [plugins/nodebb-theme-lavender] In the event of an unresponsive NodeBB caused by this plugin, run ./nodebb reset plugin="nodebb-theme-lavender".

Is this normal for 0.7?

psychobunny

I get them too, we usually don't get around to fixing those warnings until stable is near release

hek

@psychobunny

Ok, good to hear

Upgrade to 1.7 finished. I only had to disable the nodebb-plugin-topic-badges plugin as it resulted in crashes.

We got two search icons in the header now also. Is that "as designed"?

17/3 19:13 [14062] - error: TypeError: Object #<Object> has no method 'push'
    at Object.TopicBadges.addThreadTools [as method] (/usr/mysensors/mysensors-forum/NodeBB/node_modules/nodebb-plugin-topic-badges/library.js:27:15)
    at /usr/mysensors/mysensors-forum/NodeBB/src/plugins/hooks.js:89:12
    at /usr/mysensors/mysensors-forum/NodeBB/node_modules/async/lib/async.js:272:13
    at iterate (/usr/mysensors/mysensors-forum/NodeBB/node_modules/async/lib/async.js:149:13)
    at Object.async.eachSeries (/usr/mysensors/mysensors-forum/NodeBB/node_modules/async/lib/async.js:165:9)
    at Object.async.reduce (/usr/mysensors/mysensors-forum/NodeBB/node_modules/async/lib/async.js:271:15)
    at fireFilterHook (/usr/mysensors/mysensors-forum/NodeBB/src/plugins/hooks.js:81:9)
    at Plugins.fireHook (/usr/mysensors/mysensors-forum/NodeBB/src/plugins/hooks.js:66:5)
    at Object.threadTools (/usr/mysensors/mysensors-forum/NodeBB/node_modules/async/lib/async.js:656:23)
    at /usr/mysensors/mysensors-forum/NodeBB/node_modules/async/lib/async.js:583:25

<baris>

You can disable the on on the left from ACP>navigation

hek

@baris

Ohh.. sweet a new menu for handling top bar!

There is something wrong with category permissions! Many of your categories is hidden for registered users/guests (only admin=me) can see it. Tried re-saving but this seems to make it even more worse (they disappear one by one). Panic!

hek

I have to enable old disabled categories to see them. Definitely a bug somewhere in the permission-on-categories part.

hek

Reset password does dot work any more. You only get a "invalid reset code" popup.

hek

File uploads does not quite work. They end up on server but they are not shown in posts. Only appear as:

![Screen Shot 2015-03-16 at 07.19.35.png](/uploads/files/1426625913085-Screen Shot 2015-03-16 at 07.19.35.png)

Which plugin is responsible for parsing image tags? What could be the issue.

hek

I would say the filename with spaces "1426624191257-sensor shield rev 1.6 pcb.png " breaks the parsing.

Previously the files got names such as upload-2fd43287-38ca-4fb2-98c3-57120164d605.png

Panic:ing. Which component should I downgrade to get the old behaviour? marked?

hek

@baris and @psychobunny , just a gentle ping. Would love to have image uploads working again before I hit the bed here.

Do you remember when the file upload/filename last changed in master (or plugins).

psychobunny

Okay so Baris fixed the reset issue an hour or so ago, but I would not recommend updating to the latest master beyond that commit on a live forum

psychobunny

I hate to be the bearer of bad news but the other two issues are more oriented towards @baris and @julian who are AFK till the morning at worst. I hope you can cope (this is the reason why we don't recommend using a non-stable build)

Any chance of dropping back to latest stable (0.6x)? Do you have backups? Otherwise hang tight and we will try to resolve tomorrow?

hek

I can live without reset for a few days. Or cherrypick 37fe438c63359e9ce25a307aea48c752f0ce7c2a.

But image upload is worse.