Multi select dropdown in plugin settings?

[julian]

Oh, @pichalite, something to consider -- the values as saved are now JSON in the database, not comma separated (that was just the default behaviour of .toString()).

So the multiselect should save data as ['foo', 'bar', 'baz']

[pichalite]

@julian Pulled the latest code. Doesn't seem to work for me. The data is still getting saved as comma separated and I don't see the options selected after page refresh.

[julian]

You may need to clear cache?

https://github.com/NodeBB/NodeBB/commit/d096a639d6d51c02b71c243dc8b1b29f94a73007

0 julianlam committed to NodeBB/NodeBB

fixed #2657 -- there's a slight chance this might break other ACP pages, but my limited testing tells me it is ok so far

[pichalite]

@julian Tried clearing the cache, no luck. Setup a new installation of NodeBB using master, doesn't work. Am I missing something?

[julian]

What git hash are you on? git rev-parse HEAD

[pichalite]

@julian

git rev-parse HEAD
d096a639d6d51c02b71c243dc8b1b29f94a73007

[julian]

@pichalite I see where I went wrong, you don't have an id, but name is the correct property to check. One moment.

[julian]

@pichalite Okay, pull and try again.

[pichalite]

@julian Perfect, works now. Thank you.

[julian]

@pichalite Thanks for helping make NodeBB better!