This looks easy enough, thank you @yariplus!
Plugin Developers!! Read this re: v0.6.0 Breaking changes
@Schamper When you've done yours, I'm accepting PRs for mine.
Wouldn't this topic be better off in a public category, not every plugin developer might be subscribed to the dev group
@psychobunny I thought this category was only available to people in the dev group. Probably not very useful for people like shard, that are developing plugins, but can't see this topic for example.
Probably XD. Let me move it there now.
I do have a propensity for verbosity
you just summed it all up yourself
I understand the new concept but why unpublish first?
Upon reflection, the unpublishing step is unnecessary
I wonder, is it necessary to make a new branch too?
npm wouldn't just store the commit on master branch?
My bad, I didn't see it was for already 0.6.0 published plugins.
I correctly assumed (and this has been validated through actual plugin upgrades) that the
latesthash in npm points to the most recently published version, and not the highest version.
That is, given your plugin
- If v1.0.0 is compatible with v0.5.4
- If v1.1.0 is compatible only with v0.6.0
- The latter is published first
- A user typing
npm install nodebb-plugin-examplewill receive v1.0.0 of the plugin, irrespective of what NodeBB version he/she is running, even though v1.1.0 is technically newer
Now, special note: The NodeBB Package Manager doesn't do this. When the ACP calls nbbpm to request a suggested package, we query npm for the plugin data, and sort the versions before checking compatibility, so this issue is moot.