Event handlers on search button are prevented by app

[esiao]

Could be a bug or totally intended, it's more a warning than an actual bug report.

The .off() in app.js on this line
https://github.com/NodeBB/NodeBB/blob/master/public/src/app.js#L444

Is preventing to bind any events on the search button.
I needed it for my theme and had to remove the .off to make it work.
What is the function of this one in that case and why removing all the handled events ? Is there a down part in removing that ?

[julian]

We use .off().on() as a cheap way of ensuring that we don't accidentally add multiple click handlers to an element. I'm not entirely sure if that .off() is required there... @baris?

[baris]

Doesn't look like it's needed here removed on master. https://github.com/NodeBB/NodeBB/commit/c991997552483269f76176606d1fcb909e0c83d4

[esiao]

Okay, thanks guys I'm gonna pull that right now and play with it