[nodebb-plugin-soundcloud] SoundCloud embed plugin

[a_5mith]

@Batou said:

It would be awesome @kevin , because it displays the iframe code on the frontpage, I hope you can fix it soon @tedr56 because it's a great plug in.

Not sure if you're still active, but I fixed this a few weeks back, plugin works fine now, the only thing it won't do at the minute is sets. But I'll work on that today.

[kimikelku]

Is anyone having this problem? I can't make this plugin work on my forum, i get this:

error: [meta/css] Could not minify LESS/CSS: './nodebb-plugin-soundcloud/style.css' wasn't found

[tedr56]

@kimikelku Indeed, in plugin.json file, the Css path is not included in staticDirs anymore.

@julian I don't know how to fix this without breaking update of those who aren't at last nodebb version.

[a_5mith]

@tedr56 I'll take a look for you.

Edit: Sent you a pull request so it should now work. (It's probably worth pointing out though that the css inside style.css doesn't actually do anything as your iFrame doesn't have the class name applied.

[tedr56]

@a_5mith said:

Edit: Sent you a pull request so it should now work. (It's probably worth pointing out though that the css inside style.css doesn't actually do anything as your iFrame doesn't have the class name applied.

Indeed >.<

I see now the logic to be applied but aren't their a safety for people who aren't at the last nodebb version, like minver or something?

[a_5mith]

@tedr56 You can use

"minver": "0.4.0" or whatever version, stick it at the end of your plugin.json file, although I'm not sure if minver is being depreciated in 0.5.0 in favour of compatibility, I may have misread the github conversation about it.

I wouldn't worry too much either way, if they've not updated nodebb, they're not going to update the soundcloud plugin.

[tedr56]

@a_5mith @kimikelku Update merged and published.

@a_5mith minver seems deprecated, and "compatibility" is not here yet.

[a_5mith]

@tedr56 Let me know if there's any other issues, I didn't actually test it.

[kimikelku]

Its working with no problems.

[julian]

Yes, minver deprecated, though supported until 0.6.0, so don't worry about it.

[a_5mith]

I've submitted a PR for this for anyone that uses it to include soundcloud sets as well as tracks as before.

You can see the difference in the image below (sorry for the size), works the same as before, just paste the URL and it will work out if it's a track or a set and adjust the height of the iFrame for each. (The pull requested version uses the soundcloud orange, not the blue as depicted in my screenshot, I'm running a custom plugin that adds slightly different functionality which has been removed from the PR) however I can add a quick guide here if anyone wants to know how to change the play button colour.

[Kalbaskin]

@a_5mith i use nodebb 0.7.0

The plugin is not working.

[codejet]

@Kalbaskin probably just needs regex looked @.. think I had it working

[rbeer]

It is working for me, too.
But it throws a pretty nasty error, nonetheless.

I suspect that the self in question is intended to be the WebWorker in use there. WebWorker.postMessage, as opposed to window.postMessage (which the global self is set to at the time of the error being thrown), allows the second parameter to be optional.

'use strict';
/*global require, module, self*/

(function(module) {
	var templates = {
			cache: {},
			globals: {}
		},
		helpers = {},
		loader,
		worker;

	var regexes = {
		...
	};

	if (typeof self !== 'undefined' && self.addEventListener) {
		self.addEventListener('message', function(ev) {
			var data = ev.data;

			self.postMessage({ // THROWING ERROR
				result: !data.block ? templates.parse(data.template, data.object) : templates.parse(data.template, data.block, data.object),
				signature: data.signature
			});
		}, false);
	}

[a_5mith]

You can clone my personal soundcloud plugin from github.

It's more or less the same, but it supports sets and tracks, and the play button is blue, but look in library.js and remove the additional parameters if you don't want them.

[Kalbaskin]

@a_5mith it will work on 0.7.0?

[a_5mith]

I'm using it on 0.7.0, so yes. Well, it will until @julian commits the change that breaks every plugin I've made.

[Kalbaskin]

@a_5mith your plugin is not works =(

[rbeer]

@a_5mith said:

I'm using it on 0.7.0, so yes. Well, it will until @julian commits the change that breaks every plugin I've made.

plugin-youtube-lite?
Or is there really something incoming?

[a_5mith]

@rbeer said:

@a_5mith said:

I'm using it on 0.7.0, so yes. Well, it will until @julian commits the change that breaks every plugin I've made.

plugin-youtube-lite?
Or is there really something incoming?

I need to update all of my plugins at some point. However I'm currently overseeing a migration at work, so time isn't something I have a lot of. Accepting pull requests though, I believe it's just a
A change to how the regexp handles link parameters like no follow.