Mentions opens in a new tab.

Scuzz

One of our members have recently discovered a bug within either the mentions plugin or the "Open outgoing links in new tab?" option.
They were kind enough to post a video for us.

julian

@Scuzz Looks to be a combination of issues... the upstream textcomplete library uses html anchors with no attributes, which our ajaxification system doesn't know how to handle. Going to submit a pull request upstream.

<baris>

@julian said:

html anchors with no attribute

@frissdiegurke sent this a couple days back not sure if handles this case.

https://github.com/NodeBB/NodeBB/pull/1775/files

julian

@baris Looks like it should, but I'm guessing no.

Upon further reflection, it seems an anchor tag with no href attribute is perfectly valid, so I won't be submitting a patch upstream.

I imagine if href is missing, this.href would be undefined, no?

Let me add that in and see.

Edit: @Scuzz, try after this commit: https://github.com/NodeBB/NodeBB/commit/186473fa7bb6366bbaec52866a1a3dd1ae96aceb

Scuzz

I'll have to test it out. We are on stable at the moment and i dont wanna upgrade just yet.
Quick work though

frissdiegurke

@julian said:

I imagine if href is missing, this.href would be undefined, no? smile

No.

I was surprised that it's been an empty string that got checked instead of undefined too, but it seems I'm to adapted to jQuery ^^

This is because you use the DOM-element rather than jQuery to get the href:
document.createElement('a').href === ''
$('<a></a>').attr('href') === undefined