v3.10.0 -> 3.10.1 upgrade error

sweetp

@baris I ran the upgrade script 2x and got it both times

<baris>

I think it's this request that's failing.

let { response, body } = await request.get(`https://packages.nodebb.org/api/v1/suggest?version=${nbbVersion}&package[]=${toCheck.join('&package[]=')}`);

Can you load that endpoint?

sweetp

@baris how exactly?
I tried in the browser console, and get undefined.
I tried running it in Paw.cloud and get a 200 response

<baris>

For example https://packages.nodebb.org/api/v1/suggest?version=3.10.1&package[]=nodebb-plugin-imgur

sweetp

I run this in the browser console:

fetch('https://packages.nodebb.org/api/v1/suggest?version=3.10.1&package%5B%5D=nodebb-plugin-imgur')
  .then(res => res.json())
  .then(console.log)

and get this:

Promise = $1
result: undefined
status: "fulfilled"

<baris>

Seems like you can't reach that endpoint then, here is what it looks like for me.

sweetp

This post is deleted!

sweetp

looks like a cors issue:

< Promise {status: "pending"}
[Error] Origin https://support.sweetpproductions.com is not allowed by Access-Control-Allow-Origin. Status code: 404
[Error] Fetch API cannot load https://packages.nodebb.org/api/v1/suggest?version=3.10.1&package%5B%5D=nodebb-plugin-imgur due to access control checks.
[Error] Failed to load resource: Origin https://support.sweetpproductions.com is not allowed by Access-Control-Allow-Origin. Status code: 404 (suggest, line 0)
[Error] Unhandled Promise Rejection: TypeError: Load failed

julian

@sweetp Are you using some kind of proxy? That could cause issues with the ACAO header sent back from packages.nodebb.org

sweetp

when I ssh into my server I get this:

root@server:~# curl -I https://packages.nodebb.org
curl: (60) SSL: no alternative certificate subject name matches target host name 'packages.nodebb.org'
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.
root@server:~#

This happens on 2 seperate VPS servers I manage.

on my local device I see this:

curl -I https://packages.nodebb.org
HTTP/1.1 302 Found
Server: nginx/1.18.0 (Ubuntu)
Date: Wed, 09 Oct 2024 18:59:39 GMT
Content-Type: text/plain; charset=utf-8
Content-Length: 28
Connection: keep-alive
X-Powered-By: Express
Access-Control-Allow-Origin: *
Location: /stats
Vary: Accept

Something interesting, when I run the command on my local device running through a VPN I get the same error shown for my 2 remote VPS's

FrankM

Same problem.

3. Checking installed plugins for updates...Checking installed plugins and themes for updates... Warning: An unexpected error occured when attempting to verify plugin upgradability
Error occurred during upgrade: TypeError: fetch failed
    at node:internal/deps/undici/undici:13185:13
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async call (/home/user_radforum/nodebb/src/request.js:37:19)
    at async getSuggestedModules (/home/user_radforum/nodebb/src/cli/upgrade-plugins.js:78:27)
    at async checkPlugins (/home/user_radforum/nodebb/src/cli/upgrade-plugins.js:101:27)
    at async upgradePlugins (/home/user_radforum/nodebb/src/cli/upgrade-plugins.js:125:17)
    at async Object.handler (/home/user_radforum/nodebb/src/cli/upgrade.js:29:4)
    at async runSteps (/home/user_radforum/nodebb/src/cli/upgrade.js:55:5)
    at async Object.runUpgrade [as upgrade] (/home/user_radforum/nodebb/src/cli/upgrade.js:98:3)
2024-10-09T19:00:50.732Z [4568/271155] - error: uncaughtException: fetch failed
TypeError: fetch failed
    at node:internal/deps/undici/undici:13185:13
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async call (/home/user_radforum/nodebb/src/request.js:37:19)
    at async getSuggestedModules (/home/user_radforum/nodebb/src/cli/upgrade-plugins.js:78:27)
    at async checkPlugins (/home/user_radforum/nodebb/src/cli/upgrade-plugins.js:101:27)
    at async upgradePlugins (/home/user_radforum/nodebb/src/cli/upgrade-plugins.js:125:17)
    at async Object.handler (/home/user_radforum/nodebb/src/cli/upgrade.js:29:4)
    at async runSteps (/home/user_radforum/nodebb/src/cli/upgrade.js:55:5)

My nodebb version is 3.9 and i try to update to 3.10.1

sweetp

something weird is going on with your server:
Screenshot 2024-10-09 at 9.04.42 pm.jpg

julian

@sweetp what do you get when you try to dig that domain?

I'd like to see what the names of it is as well

FrankM

I got

~/nodebb$ dig packages.nodebb.org

; <<>> DiG 9.18.28-1~deb12u2-Debian <<>> packages.nodebb.org
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 50858
;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 1232
;; QUESTION SECTION:
;packages.nodebb.org.           IN      A

;; ANSWER SECTION:
packages.nodebb.org.    300     IN      A       138.197.166.38

;; Query time: 12 msec
;; SERVER: 185.12.64.2#53(185.12.64.2) (UDP)
;; WHEN: Wed Oct 09 21:42:10 CEST 2024
;; MSG SIZE  rcvd: 64

sweetp

@Julian

root@server:~# dig packages.nodebb.org +short
138.197.166.38

root@server:~# dig packages.nodebb.org less

; <<>> DiG 9.18.28-0ubuntu0.24.04.1-Ubuntu <<>> packages.nodebb.org less
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 23609
;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 2, ADDITIONAL: 13

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 65494
;; QUESTION SECTION:
;packages.nodebb.org.		IN	A

;; ANSWER SECTION:
packages.nodebb.org.	108	IN	A	138.197.166.38

;; AUTHORITY SECTION:
nodebb.org.		108	IN	NS	greg.ns.cloudflare.com.
nodebb.org.		108	IN	NS	sue.ns.cloudflare.com.

;; ADDITIONAL SECTION:
greg.ns.cloudflare.com.	108	IN	A	173.245.59.115
greg.ns.cloudflare.com.	108	IN	A	172.64.33.115
sue.ns.cloudflare.com.	108	IN	A	108.162.192.145
greg.ns.cloudflare.com.	108	IN	AAAA	2606:4700:58::adf5:3b73
sue.ns.cloudflare.com.	108	IN	AAAA	2803:f800:50::6ca2:c091
sue.ns.cloudflare.com.	108	IN	A	173.245.58.145
sue.ns.cloudflare.com.	108	IN	AAAA	2a06:98c1:50::ac40:2091
greg.ns.cloudflare.com.	108	IN	A	108.162.193.115
greg.ns.cloudflare.com.	108	IN	AAAA	2803:f800:50::6ca2:c173
greg.ns.cloudflare.com.	108	IN	AAAA	2a06:98c1:50::ac40:2173

; <<>> DiG 9.18.28-0ubuntu0.24.04.1-Ubuntu <<>> packages.nodebb.org
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 52811
;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 2, ADDITIONAL: 13

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 65494
;; QUESTION SECTION:
;packages.nodebb.org.           IN      A

;; ANSWER SECTION:
packages.nodebb.org.    86      IN      A       138.197.166.38

;; AUTHORITY SECTION:
nodebb.org.             86      IN      NS      greg.ns.cloudflare.com.
nodebb.org.             86      IN      NS      sue.ns.cloudflare.com.

;; ADDITIONAL SECTION:
sue.ns.cloudflare.com.  86      IN      A       173.245.58.145
sue.ns.cloudflare.com.  86      IN      A       172.64.32.145
greg.ns.cloudflare.com. 86      IN      AAAA    2606:4700:58::adf5:3b73
sue.ns.cloudflare.com.  86      IN      AAAA    2803:f800:50::6ca2:c091
greg.ns.cloudflare.com. 86      IN      A       173.245.59.115
greg.ns.cloudflare.com. 86      IN      A       172.64.33.115
sue.ns.cloudflare.com.  86      IN      AAAA    2606:4700:50::adf5:3a91
sue.ns.cloudflare.com.  86      IN      A       108.162.192.145
greg.ns.cloudflare.com. 86      IN      A       108.162.193.115
greg.ns.cloudflare.com. 86      IN      AAAA    2a06:98c1:50::ac40:2173
sue.ns.cloudflare.com.  86      IN      AAAA    2a06:98c1:50::ac40:2091
greg.ns.cloudflare.com. 86      IN      AAAA    2803:f800:50::6ca2:c173

;; Query time: 0 msec
;; SERVER: 127.0.0.53#53(127.0.0.53) (UDP)
;; WHEN: Wed Oct 09 21:44:20 CEST 2024
;; MSG SIZE  rcvd: 382

sweetp

@Julian https://packages.nodebb.org loads this url: otherhome.ca

julian

@sweetp @FrankM seems the site is working again?

sweetp

@Julian it still redirecting to otherhome.ca for me. dig is also still showing 138.197.166.38 and the fetch request still fails

julian

@sweetp At this point I'm still suspecting some sort of DNS misconfiguration or other MITM-style redirection.

@FrankM Are you also seeing the wrong site when you go to packages.nodebb.org ?

FrankM

@julian Yes i do. My location is germany.