Make nodebb-plugin-emailer-mailjet compatible with 3.x

phenomlab

Re: [nodebb-plugin-emailer-mailjet] Mailjet Integration

Hi @baris @julian @pichalite can we please make this plugin compatible with v3.x ? I'm helping someone out who is based on the other side of the world (Australia - I'm in the UK), so getting together isn't easy - but I have access to their domain and site etc, so this would be ideal if I could use this plugin once compatible.

Or, alternatively, let me know if there is a way I can make this work myself?

Error is as below (console)

emailer-mailjet:594 Uncaught ReferenceError: require is not defined
    at emailer-mailjet:594:2

Thanks

<baris>

What version of the plugin are you using?

julian

I wonder what line 594 is referring to... the plugin (my fork) only contains 71 lines in library.js

phenomlab

@baris umm .. the one in the included post which come to think of it is probably really old...

julian

Yeah it was up to date with latest v1 changes, but there have been some... more changes... since My fork is the same as his branch though.

julian

Ah, hah. Yes, this plugin is so old it contains javascript in the ACP template

julian

@phenomlab https://www.npmjs.com/package/@nodebb-community/nodebb-plugin-emailer-mailjet

phenomlab

@julian awesome. Thanks

phenomlab

@julian I'm not sure this is working properly. It installs and saves API key and secret, but this appears in the logs

2023-08-24T17:07:50.809Z [4567/2323164] - error: [plugins/emailer-mailjet] API key or SECRET Key not set!

And when I send a test email

2023-08-24T17:09:04.141Z [4567/2323164] - error: [emailer.mailjet] Mailjet is not set up properly!

<baris>

@phenomlab Looks like there is a typo in the plugin, I will fix that.

phenomlab

@baris thanks

<baris>

Can you try with 2.0.2?

phenomlab

@baris - yep - thanks. BTW - on my browser, the reply arrow button no longer works??

phenomlab

@baris - the error stating that the API key is not set has resolved, but still see this on each submit

2023-08-24T17:23:17.917Z [4567/2323571] - error: [emailer.mailjet] Mailjet is not set up properly!

<baris>

@phenomlab not sure what's wrong but the plugin was using a really old version of mailjet dependency so I upgraded that. https://github.com/NodeBB-Community/nodebb-plugin-emailer-mailjet/commit/15fa69228f1f4b6b5917c210c5a099fa1b97aa25

New version is 3.0.0 give it a shot.

phenomlab

@baris Thanks

<baris>

Looks like they no longer support commojs on latest version so it might need more modifications https://github.com/mailjet/mailjet-apiv3-nodejs/issues/255

phenomlab

@baris Yes, it still shows the same error messages, and the email doesn't arrive (although the ACP says it was sent)

<baris>

What about 3.0.1? Make sure you rebuild/restart after upgrading plugin. Let me know if you get any error messages.

phenomlab

@baris Testing now. Thanks

EDIT - same unfortunately.