Collapsing blockquotes on Harmony

[dave1904]

Hi there,

i posted this question on Sudonix before (not sure if I'm allowed to post a link here), @phenomlab noted it was a feature on persona and that it could be a good idea to address this issue to the developers, as it could have been overlooked:

On Harmony theme blockquotes are not collapsing as it seems. Or am I missing a setting? If there are nested, long quotes it can be a scrolling marathon on mobile devices.

For example, here the whole screen is filled by quotes and it's only 2 nested quotes:

Best regards
David

[baris]

Thanks for reporting this is fixed in the next version
https://github.com/NodeBB/nodebb-theme-harmony/commit/e676db1807dd9448f70912843ad09fafd67ca680
https://github.com/NodeBB/NodeBB/commit/6aae88d5dd48d46d5943f94bd5226224b37d07f4

[dave1904]

Hi, I updated to v3.1.5 but couldn't see a difference to the quotes.

[baris]

The fix is going to be in 3.2.0

[BrotherGlaucon]

@baris Will the fix apply to Lavender as well, which has the same issue?

[baris]

Yes will be fixed in lavender as well

[dave1904]

On my forum I've noticed a strange behaviour of the collapsing block quotes which I'm still trying to reproduce. Sometimes the quotes are collapsed with toggle sometimes they are not without toggle.

Uncollapsed:

Collapsed:

[baris]

@dave1904 can you share a link to that post that has 3 nested quotes?

[dave1904]

@baris Yes, here

[baris]

Seems to happen because of a plugin that wraps the elements in the post/content.

Try disabling the light gallery plugin to confirm.

[dave1904]

@baris confirmed, it was the light gallery plugin

[baris]

Maybe we can relax the selector we use in core for blockquotes so it works with lightbox, I will take a look.

[phenomlab]

@dave1904 You can use Fancybox very simply to replace this - I have it running on my site.

[dave1904]

@phenomlab Thanks, will have a look!

[baris]

The issue with lightbox will be fixed in 3.5.0

blockquote collapsing stops working if plugins modify/wrap `post/content` elements · Issue #12062 · NodeBB/NodeBB

from https://community.nodebb.org/post/96326

GitHub (github.com)