How to improve popular posts response time?

<baris>

It would look something like this

myPlugin.actionTopicReply = async function (hookData) {
	const userGroups = await Groups.getUserGroupMembership('groups:visible:createtime', [hookData.data.uid]);       	
	const isInDevGroup = userGroups.flat().includes('My developer group');
	if (isInDevGroup) {
		await topics.setTopicField(hookData.topic.tid, 'postedInByDeveloper', 1);
	}
};

So essentially you save a field into the topic object if a developer posts in it. This way you don't need to calculate it each time the topic list is loaded.

patsanch

Awesome! Thank you so much! We'll try that.

patsanch

This won't retro, but you're right, calculating on post is better than calculating on fetch for each.

<baris>

You might want to use both action:topic.reply and action:topic.post one is triggered on reply and one is triggered when a new topic is posted. Also if the developer group is visible then you can use const userGroups = await Groups.getUserGroupMembership('groups:visible:createtime', [hookData.data.uid]); and it will be even faster.

patsanch

Yes, the group is visible. I'll try the updated snippet.

I'll also add it to both hooks.

Thank you so much!

patsanch

Woot! It's working on our development environment. Only change I made from the snippet was

hookData.topic.tid to hookData.post.topic.tid

Thanks for your help!

<baris>

No problem

patsanch

Just wanted to add what a huge difference our current JMeter tests is telling us. Now we can bump the number of threads to see how much our current set up can handle.

Thank you!

<baris>

I just realized there is a much simpler way to do this, since you only seem to care about if the user is in a special dev group you don't need to load the user's groups, you can just check if they are in that special group.

myPlugin.actionTopicReply = async function (hookData) {
	const isInDevGroup = await Groups.isMember(hookData.data.uid, 'My developer group');
	if (isInDevGroup) {
		await topics.setTopicField(hookData.topic.tid, 'postedInByDeveloper', 1);
	}
};

patsanch

Nice! Thanks baris! I agree that's simpler