3.0.0 Bug Report Thread

[brazzerstop]

I get blank page with error Internal Server Error after sync my theme fork with Harmony and have this error in logs:

TypeError: meta.css.getSkinSwitcherOptions is not a function
    at Object.library.filterMiddlewareRenderHeader [as method] (/var/www/nodebb/node_modules/nodebb-theme-community/library.js:200:63)
    at fireMethod (/var/www/nodebb/src/plugins/hooks.js:164:25)
    at Object.fireFilterHook [as filter] (/var/www/nodebb/src/plugins/hooks.js:195:18)
    at Hooks.fire (/var/www/nodebb/src/plugins/hooks.js:132:49)
    at Object.wrapperCallback [as fire] (/var/www/nodebb/src/promisify.js:46:11)
    at renderHeader (/var/www/nodebb/src/middleware/render.js:311:42)
    at renderHeaderFooter (/var/www/nodebb/src/middleware/render.js:370:17)
    at renderMethod (/var/www/nodebb/src/middleware/render.js:89:14)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async ServerResponse.renderOverride [as render] (/var/www/nodebb/src/middleware/render.js:111:5)

History - https://github.com/ferumdev/nodebb-theme-community/commit/365e7dfe4190a5365df0dfca4f20e61d486482eb

NodeBB 3.1.6

When I switch to default theme Harmony, I don't have this errors. How I can fix it?

[phenomlab]

@brazzerstop you may need to copy that function from Harmony and include that in your forked theme. I had a similar issue that despite the function already being declared, I couldn't call it without adding it in the custom theme.

Never got to the bottom of it as I abandoned the custom theme anyway.

[baris]

@brazzerstop use develop branch for core

[brazzerstop]

@baris yeah on develop everything is worked! Thank you!

[brazzerstop]

Need fix a width for thumbnails in Harmony.

Maybe try this solution for topics list:
https://github.com/NodeBB/nodebb-theme-harmony/blob/main/templates/partials/topics_list.tpl#L66

add class: bg-light rounded-1
add style: max-width: 5.33rem; height: 3.33rem; object-fit: contain;

Result

Thumbs
https://github.com/NodeBB/nodebb-theme-harmony/blob/main/templates/partials/topic/thumbs.tpl#L3

add class: bg-light rounded-1
add style: max-width: 5.33rem; object-fit: contain;

Result

[baris]

@brazzerstop thanks for reporting filed an issue here https://github.com/NodeBB/NodeBB/issues/11724

[brazzerstop]

On page admin/advanced/events button for remove all events (after filter btn) reload page and not clearing events.

[baris]

@brazzerstop is this happening on 3.1.6 or develop branch?

[brazzerstop]

@baris Yes, on develop

[baris]

@brazzerstop Fixed in https://github.com/NodeBB/NodeBB/commit/281078f5ce782b2d1f85c7cb41dd24b17ad9d15a

[brazzerstop]

Guys, what do you think about change color for the read/unread topics?
I think accent primary color should be associated with actions, not labels.

Default dark color for the unread topics:

.skin-noskin ul.topics-list li.unread .title {
    color: #282c30;
}

and grey for the read topics, like this color: #989b9e;

vs

[eeeee]

There are some small but annoying bugs, Im trying to counter each with CSS fixes, and work arounds.
I dont know if small things Nodebb devs want to hear about?
An example is in Admin, a floating title is printed in White text. Its unnecessary, (because there are other headers on page) and its mostly invisible anyway. The issue is you start to see outline of it when you may be typing something!
For example on widgets page, this text looks corrupted, but its just 'widgets' is a floating white text header. It starts to show when there is text behind it.

[eeeee]

This post is deleted!

[brazzerstop]

Please change z-index for mobile navigator when Composer is open

[baris]

@brazzerstop that's tablet resolution?

[brazzerstop]

@baris yes, iPad in vertical screen orientation

[brazzerstop]

Create Token button on page admin/settings/api not work when click. NodeBB (develop)

[baris]

@brazzerstop fixed in https://github.com/NodeBB/NodeBB/issues/11773, thanks for reporting.

[phenomlab]

@baris on

[crazycells]

Categories pagination toolbar is very tiny for my fingers on mobile. I keep pressing wrong box.