Upgrade error: fullname.substr is not a function

[eesty]

Hi,

I've been trying to run an upgrade from 1.14.3 to 1.16.1 however the upgrade is failing at the "Create fullname search set" stage.

The error reads:

→ [2020/9/11] Create fullname search set...
    [##           ] (1000/4613) 21% Error occurred
Error occurred during upgrade: TypeError: u.fullname.substr is not a function
    at userData.filter.map.u (/home/wtf/NodeBB/src/upgrades/1.15.0/fullname_search_set.js:19:49)
    at Array.map (<anonymous>)
    at batch.processSortedSet.batch (/home/wtf/NodeBB/src/upgrades/1.15.0/fullname_search_set.js:19:6)
    at process._tickCallback (internal/process/next_tick.js:68:7)
2021-01-17T14:26:01.301Z [4567/27161] - error: uncaughtException: u.fullname.substr is not a function
TypeError: u.fullname.substr is not a function
    at userData.filter.map.u (/home/wtf/NodeBB/src/upgrades/1.15.0/fullname_search_set.js:19:49)
    at Array.map (<anonymous>)
    at batch.processSortedSet.batch (/home/wtf/NodeBB/src/upgrades/1.15.0/fullname_search_set.js:19:6)
    at process._tickCallback (internal/process/next_tick.js:68:7) {"error":{},"stack":"TypeError: u.fullname.substr is not a function\n    at userData.filter.map.u (/home/wtf/NodeBB/src/upgrades/1.15.0/fullname_search_set.js:19:49)\n    at Array.map (<anonymous>)\n    at batch.processSortedSet.batch (/home/wtf/NodeBB/src/upgrades/1.15.0/fullname_search_set.js:19:6)\n    at process._tickCallback (internal/process/next_tick.js:68:7)","exception":true,"date":"Mon Jan 18 2021 01:26:01 GMT+1100 (Australian Eastern Daylight Time)","process":{"pid":27161,"uid":0,"gid":0,"cwd":"/home/wtf/NodeBB","execPath":"/root/.nvm/versions/node/v10.15.3/bin/node","version":"v10.15.3","argv":["/root/.nvm/versions/node/v10.15.3/bin/node","/home/wtf/NodeBB/nodebb","upgrade"],"memoryUsage":{"rss":139489280,"heapTotal":113721344,"heapUsed":78097440,"external":22051721}},"os":{"loadavg":[2.603515625,2.49853515625,3.0625],"uptime":93440},"trace":[{"column":49,"file":"/home/wtf/NodeBB/src/upgrades/1.15.0/fullname_search_set.js","function":"userData.filter.map.u","line":19,"method":"u","native":false},{"column":null,"file":null,"function":"Array.map","line":null,"method":"map","native":false},{"column":6,"file":"/home/wtf/NodeBB/src/upgrades/1.15.0/fullname_search_set.js","function":"batch.processSortedSet.batch","line":19,"method":"batch","native":false},{"column":7,"file":"internal/process/next_tick.js","function":"process._tickCallback","line":68,"method":"_tickCallback","native":false}]}

The error suggests to me that there is an issue with someone's full name.

Some background info: my forum was originally a phpbb forum, which migrated to Discourse then finally to NodeBB. It's possible that a legacy username is invalid.

[baris]

@eesty thanks for reporting, I'll take a look.

[baris]

Let me know if it works after applying this change.
https://github.com/NodeBB/NodeBB/commit/4fb907875e31501a28427c7ec1e41b4862649e35

[eesty]

success!
thanks