Favicon reset to NodeBB after upgrade
-
Nothing worse than spending hours upgrading only to spend hours afterwards because your favicon has been replaced.
I have literally deleted the favicon from the file system and something still shows up. No matter what I do, the BB icon still persists.
Thanks in advance for any help.
-
Oh, not this again.Turns out it's just cosmetic, I think the page loads the right thing.My forum in installed in a subdirectory under
/forums
. @barisAlthough,. not sure why this messes with the favicon.
-
A reboot seemed to help. Though, I'm still not sure why it shows the 16x16 icon instead of the nice Progressive Web icon
-
I think this happens because the serve-favicon dependency caches the icon so a rebuild&restart is necessary to see the new icon.
https://github.com/NodeBB/NodeBB/blob/master/src/webserver.js#L206
I am not sure about the touch icons https://github.com/NodeBB/NodeBB/blob/master/src/meta/tags.js#L78-L140 since they don't see to be using the cache buster so it might take a while for those to update.