Unable to login after upgrade to 1.15

[baris]

@rcauquil Please apply the changes here https://github.com/NodeBB/NodeBB/commit/5d00b0895b0db961775b22ba6fff0b52fa7c4a0b

It will go back to the 1.14.x version of the redirect but also fix the "%5Bobject%20Object%5D" issue that was mentioned earlier in this topic.

Let me know if it works now.

0 barisusakli committed to NodeBB/NodeBB

fix: sso redirect on /login & /api/login

[rcauquil]

@baris same behavior so far, not redirecting

[rcauquil]

@baris if you want to make it easier we can make a quick call on jitsi or discord

[rcauquil]

@baris

[baris]

Did you rebuild and restart after applying all the fixes?
I'll take a look again. Also does it work on cold load?

[rcauquil]

@baris yes if I cold load it redirect me as expected, and yes I'm doing a rebuild every time I change something

[baris]

@rcauquil said in Unable to login after upgrade to 1.15:

@baris

This output doesn't look correct it should be {external: '/auth/pycom-sso'} in the responseJSON with the latest fixes when you click the login link.

[baris]

I have tested the fix on this forum with just the facebook sso plugin enabled and it worked as expected. Cold loading /login redirects to facebook login and clicking on the login button gets back {external: '/auth/facebook'} which also triggers the facebook auth flow.

[baris]

This fix is included in 1.15.5 https://github.com/NodeBB/NodeBB/releases/tag/v1.15.5.

It only happens when you disable local login for registered users, change registration type to No registration and have 1 SSO plugin active. In this case cold loading the /login route will automatically redirect to the auth route. Clicking the login link in the header will get {external: '/auth/route-to-sso'} from the server and redirect to that route here.

[rcauquil]

@baris sorry for the late reply I'm based in Europe.
Thank you very much, it's working great now.